Fix(eos_cli_config_gen): Fix name-servers jinja templates to allow non-vrf nameservers #1451
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
role: eos_cli_config_gen
tgodaA
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
name-servers.j2 is missing a condition to handle non-vrf (vrf default) name servers.
In previous versions the code existed (inline) and I think it was accidently removed during refactoring.
Related Issue(s)
Fixes #N/A
Component(s) name
arista.avd.eos_cli_config_genProposed changes
add condition to also cover output rendering of no vrf is defined
model unchanged
How to test
molecule test only covers scenario with vrf, so maybe this is why we didn't catch the issue?
Checklist
User Checklist
Repository Checklist