Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add ISIS authentication and hello padding #1453

Merged
merged 5 commits into from
Jan 26, 2022
Merged

Feat(eos_cli_config_gen): Add ISIS authentication and hello padding #1453

merged 5 commits into from
Jan 26, 2022

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add ISIS authentication and hello padding

Related Issue(s)

Needed for PR #1418

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

On ethernet_interfaces and port_channel_interfaces:

    isis_hello_padding: < true | false >
    isis_authentication_mode: < text | md5 >
    isis_authentication_key: < encrypted password >

How to test

Molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 24, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Jan 24, 2022
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Jan 24, 2022
emilarista
emilarista approved these changes Jan 24, 2022
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

ankudinov
ankudinov reviewed Jan 25, 2022
View reviewed changes
Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

added a few minor comments

ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md Outdated Show resolved Hide resolved
...tions/arista/avd/molecule/eos_cli_config_gen/inventory/host_vars/port-channel-interfaces.yml Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md Outdated Show resolved Hide resolved
tgodaA
tgodaA approved these changes Jan 25, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 30a4078 into aristanetworks:devel Jan 26, 2022
ankudinov
ankudinov reviewed Jan 26, 2022
View reviewed changes
Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ClausHolbechArista added a commit to ClausHolbechArista/avd that referenced this pull request Jan 27, 2022
@ClausHolbechArista
Feat(eos_cli_config_gen): Add ISIS authentication and hello padding (a…
3ec5bba 
…ristanetworks#1453)
@ClausHolbechArista ClausHolbechArista added this to the v3.3.0 milestone Feb 18, 2022
@ClausHolbechArista ClausHolbechArista deleted the isis-interface-knobs branch December 22, 2022 07:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ankudinov ankudinov ankudinov left review comments

@tgodaA tgodaA tgodaA approved these changes

@emilarista emilarista emilarista approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@titom73 titom73 Awaiting requested review from titom73

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ClausHolbechArista @ankudinov @emilarista @tgodaA