Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add spanning_tree_guard to switched ethernet interfaces #1460

Merged
merged 5 commits into from
Feb 1, 2022

Conversation

ccsnw
Copy link
Contributor

@ccsnw ccsnw commented Jan 27, 2022

Change Summary

Adding support for:

spanning_tree_guard: < loop | root | none >

to ethernet_interfaces

Related Issue(s)

Fixes #N/A

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

  • Simple change to allow for "spanning-tree guard" config
  • Extended existing datamodel with additonal option:
ethernet_interfaces:
  <snip>
  spanning_tree_guard: < loop | root | disabled >
  • Skipped doc. update because other spanning-tree options are also not explicitly rendered in doc (besides in the config snippet)

How to test

Molecule test

Checklist

User Checklist

  • N/A

Repository Checklist

  • [x ] My code has been rebased from devel before I start
  • [x ] I have read the CONTRIBUTING document.
  • [o ] My change requires a change to the documentation and documentation have been updated accordingly.
  • [x ] I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Jan 27, 2022
@github-actions github-actions bot requested a review from titom73 January 27, 2022 15:52
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jan 27, 2022
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@xaviramon xaviramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@ccsnw Can I ask you to add the same to port_channel_interfaces so we avoid too many deviations? Thanks

@ccsnw
Copy link
Contributor Author

ccsnw commented Feb 1, 2022

@ccsnw Can I ask you to add the same to port_channel_interfaces so we avoid too many deviations? Thanks

sure, coming up soon

@ccsnw ccsnw requested a review from a team as a code owner February 1, 2022 13:26
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for another great contribution!

@ClausHolbechArista ClausHolbechArista merged commit e7b0d33 into aristanetworks:devel Feb 1, 2022
@ClausHolbechArista ClausHolbechArista added this to the v3.3.0 milestone Feb 18, 2022
@ccsnw ccsnw deleted the ethernet_switched branch March 25, 2022 12:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants