Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Fixing template errors and invalid config when configuring cloudvision as a service #1470

Merged
merged 5 commits into from
Feb 1, 2022
Merged

Fix(eos_designs): Fixing template errors and invalid config when configuring cloudvision as a service #1470

merged 5 commits into from
Feb 1, 2022

Conversation

emilarista
Copy link
Contributor

Change Summary

Fixed bug causing cvp_instance_ip variable value containing "arista.io" to error out the template.

Component(s) name

arista.avd.eos_designs

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the role: eos_designs issue related to eos_designs role label Jan 31, 2022
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_designs): cvp_instance_ip containing "arista.io" breaks generate structured config task Fix(eos_designs): Fixing tTemplate errors and invalid config when configuring CVaaS Feb 1, 2022
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_designs): Fixing tTemplate errors and invalid config when configuring CVaaS Fix(eos_designs): Fixing template errors and invalid config when configuring CVaaS Feb 1, 2022
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_designs): Fixing template errors and invalid config when configuring CVaaS Fix(eos_designs): Fixing template errors and invalid config when configuring cloudvision as a service Feb 1, 2022
@emilarista emilarista requested a review from a team as a code owner February 1, 2022 13:41
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 1, 2022
tgodaA
tgodaA approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ClausHolbechArista
ClausHolbechArista approved these changes Feb 1, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 93556ef into aristanetworks:devel Feb 1, 2022
@ClausHolbechArista ClausHolbechArista added this to the v3.3.0 milestone Feb 18, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@noredistribution noredistribution noredistribution left review comments

@tgodaA tgodaA tgodaA approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann Awaiting requested review from carlbuchmann

@ankudinov ankudinov Awaiting requested review from ankudinov

Assignees

@emilarista emilarista

Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
4 participants
@emilarista @noredistribution @ClausHolbechArista @tgodaA