Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Support cos in policy-map and service-policy in qos profile #1504

Merged
merged 3 commits into from
Feb 17, 2022
Merged

Feat(eos_cli_config_gen): Support cos in policy-map and service-policy in qos profile #1504

merged 3 commits into from
Feb 17, 2022

Conversation

tgodaA
Copy link
Contributor

@tgodaA tgodaA commented Feb 16, 2022

Change Summary

Added knobs to set cos and its value in policy_maps, and qos service_policy in qos_profiles.

Related Issue(s)

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Added the new knobs:

  1. cos
policy_maps:
  qos:
    < policy-map name >:
      classes:
        < class name >:
          set:
            cos: < cos_value >
  1. service_policy
qos_profiles:
  < profile_name >:
    service_policy:
      type:
        qos_input: < policy_map_name >

How to test

molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@tgodaA tgodaA requested a review from a team as a code owner February 16, 2022 23:55
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 16, 2022
carlbuchmann
carlbuchmann approved these changes Feb 17, 2022
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGMT!

@carlbuchmann carlbuchmann added this to the v3.3.0 milestone Feb 17, 2022
emilarista
emilarista approved these changes Feb 17, 2022
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 5ace05a into aristanetworks:devel Feb 17, 2022
@tgodaA tgodaA deleted the qos branch February 18, 2022 15:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilarista emilarista emilarista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@tgodaA tgodaA

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
v3.3.0
Development

Successfully merging this pull request may close these issues.
3 participants
@tgodaA @carlbuchmann @emilarista