Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: collection ansible-test linting issues #1520

Merged
merged 5 commits into from
Feb 19, 2022
Merged

Fix: collection ansible-test linting issues #1520

merged 5 commits into from
Feb 19, 2022

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Feb 18, 2022 •
edited by carlbuchmann
Loading

Change Summary

  • Fix various linting issues reported by ansible-lint.
  • Update CI pipeline to catch these issues.

Component(s) name

Various plugins.

How to test

from ./ansible-avd/ansible_collections/arista/avd run:
ansible-test sanity --requirements --docker --skip-test import --python 3.8

View CI results.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added the module: inventory_to_container issue related to inventory_to_container module label Feb 18, 2022
@github-actions github-actions bot added the type: code quality CI and development toolset label Feb 18, 2022
@carlbuchmann carlbuchmann changed the title minor fixes Fix: collection ansible-test linting issues Feb 18, 2022
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated type: documentation Improvements or additions to documentation labels Feb 18, 2022
@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review February 18, 2022 17:59
@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner February 18, 2022 17:59
tgodaA
tgodaA approved these changes Feb 18, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

carlbuchmann
carlbuchmann approved these changes Feb 19, 2022
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit a6434aa into aristanetworks:devel Feb 19, 2022
@ClausHolbechArista ClausHolbechArista added this to the v3.3.1 milestone Feb 20, 2022
@ClausHolbechArista ClausHolbechArista deleted the fix-linting-errors branch December 22, 2022 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
module: inventory_to_container issue related to inventory_to_container module role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated type: code quality CI and development toolset type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v3.3.1
Development

Successfully merging this pull request may close these issues.
3 participants
@ClausHolbechArista @carlbuchmann @tgodaA