Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add support for changing the notification timestamp mode for gnmi (Issues/1532) #1533

Merged
merged 6 commits into from
Mar 21, 2022
Merged

Feat(eos_cli_config_gen): Add support for changing the notification timestamp mode for gnmi (Issues/1532) #1533

merged 6 commits into from
Mar 21, 2022

Conversation

noredistribution
Copy link
Contributor

@noredistribution noredistribution commented Feb 22, 2022 •
edited by tgodaA
Loading

Change Summary

added support for notification timestamp send-time under management api gnmi that was introduced in EOS 4.27.0F (ref: https://aristanetworks.github.io/openmgmt/configuration/openconfig/#telemetry-timestamps)

Related Issue(s)

Fixes #1532

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

didn't modify the existing data model, just added another key for set_send_time

How to test

add set_send_time: true under management_api_gnmi in the fabric group_vars

management_api_gnmi:
  set_send_time: true
  enable_vrfs:
    MGMT:
    #  access_group: test1
  octa: true

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@noredistribution noredistribution requested a review from a team as a code owner February 22, 2022 02:30
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Feb 22, 2022
@ClausHolbechArista
Copy link
Contributor

I have changed to draft. Please fix all test failures first. Then click "ready for review"

@ClausHolbechArista ClausHolbechArista marked this pull request as draft February 22, 2022 09:19
@noredistribution noredistribution changed the title Issues/1532 Feat(eos_cli_config_gen): Add support for changing the notification timestamp mode for gnmi (Issues/1532) Feb 22, 2022
@noredistribution noredistribution marked this pull request as ready for review February 22, 2022 15:04
ClausHolbechArista
ClausHolbechArista reviewed Mar 10, 2022
View reviewed changes
...ista/avd/molecule/eos_cli_config_gen/inventory/host_vars/management-gnmi-new-flags-novrf.yml Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/management-api-gnmi.j2 Outdated Show resolved Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-api-gnmi.j2 Show resolved Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-api-gnmi.j2 Outdated Show resolved Hide resolved
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/management-api-gnmi.j2 Show resolved Hide resolved
...sta/avd/molecule/eos_cli_config_gen/documentation/devices/management-gnmi-new-flags-novrf.md Outdated Show resolved Hide resolved
@github-actions github-actions bot added the state: conflict PR with conflict label Mar 15, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 16, 2022
ClausHolbechArista
ClausHolbechArista approved these changes Mar 17, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM @noredistribution please check it again, since I had to rebase etc.

@tgodaA
Copy link
Contributor

tgodaA commented Mar 21, 2022

Need to run molecule for eos_cli_config_gen. Because the octa is tested with a regular defined test the artifacts are generated now for the old examples.

tgodaA
tgodaA approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 3a476ef into aristanetworks:devel Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@tgodaA tgodaA tgodaA approved these changes

@ankudinov ankudinov Awaiting requested review from ankudinov

Assignees

@noredistribution noredistribution

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Add support for changing the notification timestamp mode for gnmi
3 participants
@noredistribution @ClausHolbechArista @tgodaA