Feat(eos_designs): macsec support fabric links #1506 #1538
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sync with original devel branch
sync with parent branch
sync with parent
sync with parent
This reverts commit a4a0d8e.
github-actions
bot
added
role: eos_designs
ankudinov
changed the title
xaviramon
reviewed
Feb 25, 2022
ansible_collections/arista/avd/roles/eos_designs/doc/fabric-topology.md
Outdated
Show resolved
Hide resolved
| @@ -25,6 +25,10 @@ topology: | |||
| {% if switch.uplink_ptp.enable is arista.avd.defined %} | |||
| ptp: {{ switch.uplink_ptp.enable }} | |||
| {% endif %} | |||
| {% if switch.uplink_macsec.profile is arista.avd.defined %} | |||
| mac_security: | |||
There was a problem hiding this comment.
you could just do mac_security: {{ switch.uplink_macsec }} so any other future options are caried along.
Adjust the if above to just test for uplink_macsec is arista.avd.defined
...lections/arista/avd/molecule/eos_designs-twodc-5stage-clos/inventory/group_vars/DC1_POD1.yml
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Introduce a node key to enable MacSec on all uplinks.
Related Issue(s)
Fixes #1506
Component(s) name
arista.avd.eos_designsProposed changes
Following key will be added uplink management and follow the same logic as uplink_ptp, etc.
How to test
molecule converge --scenario-name eos_designs-twodc-5stage-clos
Checklist
Repository Checklist