Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add router_bgp rib-in pre-policy retain to eos_cli_config_gen #1559

Merged
merged 23 commits into from
Mar 14, 2022
Merged

Feat(eos_cli_config_gen): Add router_bgp rib-in pre-policy retain to eos_cli_config_gen #1559

merged 23 commits into from
Mar 14, 2022

Conversation

ryanmerolle
Copy link
Contributor

@ryanmerolle ryanmerolle commented Mar 3, 2022 •
edited
Loading

Change Summary

Add rib-in pre-policy retain options are missing for router_bgp neighbors, peer-groups, etc

Related Issue(s)

Fixes #1288

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Introduces a new key and templates (see linked issue):

router_bgp:
  peer_groups:
    test:
         rib_in_pre_policy_retain:
           enabled: < true | false >
           all: < true | false >
  neighbors:
    10.10.10.10:
         rib_in_pre_policy_retain:
           enabled: < true | false >
           all: < true | false >

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ryanmerolle ryanmerolle requested a review from a team as a code owner March 3, 2022 02:37
@ryanmerolle
Copy link
Contributor Author

tests will come once I get some feedback on approach

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Mar 3, 2022
@ryanmerolle ryanmerolle changed the title Add router_bgp rib-in pre-policy retain to eos_cli_config_gen draft:Add router_bgp rib-in pre-policy retain to eos_cli_config_gen Mar 3, 2022
@ryanmerolle ryanmerolle changed the title draft:Add router_bgp rib-in pre-policy retain to eos_cli_config_gen Add router_bgp rib-in pre-policy retain to eos_cli_config_gen Mar 3, 2022
@ryanmerolle ryanmerolle changed the title Add router_bgp rib-in pre-policy retain to eos_cli_config_gen Feat(eos_cli_config_gen): Add router_bgp rib-in pre-policy retain to eos_cli_config_gen Mar 3, 2022
@ClausHolbechArista
Copy link
Contributor

Moved to draft until molecule etc is ready

@ClausHolbechArista ClausHolbechArista marked this pull request as draft March 7, 2022 07:26
@github-actions github-actions bot added the state: conflict PR with conflict label Mar 7, 2022
@github-actions
Copy link

github-actions bot commented Mar 7, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation labels Mar 9, 2022
@ryanmerolle ryanmerolle closed this Mar 9, 2022
@ryanmerolle ryanmerolle reopened this Mar 9, 2022
@github-actions github-actions bot removed the state: conflict PR with conflict label Mar 9, 2022
@github-actions
Copy link

github-actions bot commented Mar 9, 2022

Conflicts have been resolved. A maintainer will review the pull request shortly.

@ryanmerolle ryanmerolle marked this pull request as ready for review March 10, 2022 00:32
@ryanmerolle
Copy link
Contributor Author

@ClausHolbechArista this is ready to review

@ClausHolbechArista ClausHolbechArista requested a review from a team March 10, 2022 06:42
ClausHolbechArista
ClausHolbechArista approved these changes Mar 11, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanmerolle
Copy link
Contributor Author

Ready for review

ClausHolbechArista
ClausHolbechArista reviewed Mar 14, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Since you added the coverage for vrf neighbors and peer-groups to the documentation template, it would be good to get this added in the eos template and readme as well. Thanks

emilarista
emilarista approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ryanmerolle
Copy link
Contributor Author

This should be good now.

ryanmerolle
ryanmerolle commented Mar 14, 2022
View reviewed changes
Copy link
Contributor Author

@ryanmerolle ryanmerolle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks!

@ryanmerolle
Copy link
Contributor Author

I'll fix this CI failure from the commit you added

ClausHolbechArista
ClausHolbechArista approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 4664ff1 into aristanetworks:devel Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilarista emilarista emilarista approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@xaviramon xaviramon Awaiting requested review from xaviramon

Assignees

@ryanmerolle ryanmerolle

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): router_bgp rib-in pre-policy retain missing features in eos_cli_config_gen
4 participants
@ryanmerolle @ClausHolbechArista @xaviramon @emilarista