Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Add dr_priority to pim ipv4 configuration on interface #1560

Merged
merged 5 commits into from
Mar 10, 2022
Merged

Feat(eos_cli_config_gen): Add dr_priority to pim ipv4 configuration on interface #1560

merged 5 commits into from
Mar 10, 2022

Conversation

ryanmerolle
Copy link
Contributor

@ryanmerolle ryanmerolle commented Mar 3, 2022 •
edited
Loading

Change Summary

Related Issue(s)

Fixes #1552

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Introduces a new key and templates (see linked issue):

ethernet_interfaces:
  Ethernet1:
    pim:
      ipv4:
        dr_priority:  <0-429467295>
port_channel_interfaces:
  Port-Channel1:
    pim:
      ipv4:
        dr_priority:  <0-429467295>
vlan_interfaces:
  Vlan100:
    pim:
      ipv4:
        dr_priority:  <0-429467295>

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ryanmerolle ryanmerolle requested a review from a team as a code owner March 3, 2022 02:46
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: Documentation role Updated labels Mar 3, 2022
@ryanmerolle ryanmerolle changed the title first commit Add dr_priority to pim ipv4 configuration on interface Mar 3, 2022
@ryanmerolle
Copy link
Contributor Author

Tests will come once I get confirmation if I need documentation templates since existing interface documentation templates are missing pim currently.

@ryanmerolle ryanmerolle changed the title Add dr_priority to pim ipv4 configuration on interface Feat(eos_cli_config_gen): Add dr_priority to pim ipv4 configuration on interface Mar 3, 2022
@ClausHolbechArista
Copy link
Contributor

I have submitted a new issue to add interface documentation for pim and associated knobs. You can go ahead and add molecule coverage for this one. Thanks.

@ClausHolbechArista ClausHolbechArista marked this pull request as draft March 7, 2022 07:23
@ClausHolbechArista
Copy link
Contributor

Moved to draft until molecule etc is ready

@ryanmerolle ryanmerolle closed this Mar 9, 2022
@ryanmerolle ryanmerolle reopened this Mar 9, 2022
@ryanmerolle ryanmerolle marked this pull request as ready for review March 9, 2022 15:06
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label Mar 9, 2022
@ryanmerolle
Copy link
Contributor Author

@emilarista & @ClausHolbechArista this should be good to go now. Thanks for the assistance!

emilarista
emilarista approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it looks like you need to refresh your molecule output since CI is complaining.

@xaviramon
Copy link
Contributor

Let's solve the CI stuff. We just merged #1570 and I believe this is missing here too. I am generating the molecule and will push if more changes are generated. Otherwise, looks good to me

@ryanmerolle
Copy link
Contributor Author

@ClausHolbechArista anytime in the next few days, would you be able to review? Thanks as always!

xaviramon
xaviramon approved these changes Mar 9, 2022
View reviewed changes
Copy link
Contributor

@xaviramon xaviramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ryanmerolle
Copy link
Contributor Author

Can this be merged and make the next minor release since it is non breaking?

@ClausHolbechArista
Copy link
Contributor

@ryanmerolle I will review and merge tomorrow.

@ryanmerolle
Copy link
Contributor Author

Thanks all!

ClausHolbechArista
ClausHolbechArista approved these changes Mar 10, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 30e1be6 into aristanetworks:devel Mar 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilarista emilarista emilarista approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@xaviramon xaviramon xaviramon approved these changes

Assignees

@ryanmerolle ryanmerolle

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Add dr_priority to pim ipv4 configuration on interfaces
4 participants
@ryanmerolle @ClausHolbechArista @xaviramon @emilarista