Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_cli_config_gen): aaa config order #1578

Merged
merged 12 commits into from
Mar 15, 2022
Merged

Fix(eos_cli_config_gen): aaa config order #1578

merged 12 commits into from
Mar 15, 2022

Conversation

ryanmerolle
Copy link
Contributor

Change Summary

Part of the various changes for getting output config to reflect config order on box.

Related Issue(s)

Fixes #1572

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Reorder aaa configuration lines & remove erroneous exclamation points.

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ryanmerolle ryanmerolle requested a review from a team as a code owner March 10, 2022 20:11
@ryanmerolle ryanmerolle mentioned this pull request Mar 10, 2022
Closed
12 tasks
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Mar 10, 2022
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): aaa config order Fix(eos_cli_config_gen): aaa config order Mar 11, 2022
@ryanmerolle
Copy link
Contributor Author

This should be ready to review.

ClausHolbechArista
ClausHolbechArista approved these changes Mar 14, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - Thank you for all your contributions!

@ClausHolbechArista ClausHolbechArista requested a review from a team March 14, 2022 14:58
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label Mar 15, 2022
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot added state: Documentation role Updated type: code quality CI and development toolset type: documentation Improvements or additions to documentation and removed state: conflict PR with conflict labels Mar 15, 2022
@ankudinov ankudinov assigned ankudinov and unassigned ankudinov Mar 15, 2022
@ankudinov ankudinov self-requested a review March 15, 2022 13:22
@ryanmerolle
Copy link
Contributor Author

It seems like the the failing job is something unrelated. Is there is anything we can do to retrigger failed jobs without pushing a commit?

@ryanmerolle
Copy link
Contributor Author

As discussed @ClausHolbechArista the enable_password changes are set.

ankudinov
ankudinov approved these changes Mar 15, 2022
View reviewed changes
Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

...e_collections/arista/avd/roles/eos_cli_config_gen/templates/documentation/enable-password.j2
@@ -11,7 +11,6 @@ sha512 encrypted enable password is configured
### Enable password configuration

```eos
!
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

if we remove starting !, may be leading ! should be removed as well?

@ClausHolbechArista ClausHolbechArista merged commit da7e3aa into aristanetworks:devel Mar 15, 2022
@ryanmerolle ryanmerolle deleted the feat_1572_aaa branch March 15, 2022 16:25
@carlbuchmann carlbuchmann added this to the v3.4.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@ankudinov ankudinov ankudinov approved these changes

Assignees

@ryanmerolle ryanmerolle

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated type: code quality CI and development toolset type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Order config output closer to EOS config order
4 participants
@ryanmerolle @ankudinov @ClausHolbechArista @carlbuchmann