Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(plugins): Add arista.avd.range_expand filter #1586

Merged
merged 3 commits into from
Mar 23, 2022
Merged

Feat(plugins): Add arista.avd.range_expand filter #1586

merged 3 commits into from
Mar 23, 2022

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Feat(plugin): Add arista.avd.range_expand filter

Component(s) name

arista.avd.range_expand

Proposed changes

Check docs

How to test

added unit testing.
run with make unit-tests from root of the repo.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner March 15, 2022 08:27
@ClausHolbechArista ClausHolbechArista changed the title Feat(plugin): Add arista.avd.range_expand filter Feat(plugins): Add arista.avd.range_expand filter Mar 15, 2022
KonikaChaurasiya-GSLab
KonikaChaurasiya-GSLab reviewed Mar 17, 2022
View reviewed changes
Copy link
Contributor

@KonikaChaurasiya-GSLab KonikaChaurasiya-GSLab left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

tgodaA
tgodaA approved these changes Mar 22, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Tested the specific unit-test with the command ansible-test units -v tests/unit/filters/test_range_expand.py from avd directory. Everything worked without any error.

@ClausHolbechArista ClausHolbechArista merged commit e70e6e1 into aristanetworks:devel Mar 23, 2022
@carlbuchmann carlbuchmann added this to the v3.4.0 milestone Apr 1, 2022
@ClausHolbechArista ClausHolbechArista deleted the arista.avd.range_expand branch December 22, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@KonikaChaurasiya-GSLab KonikaChaurasiya-GSLab KonikaChaurasiya-GSLab approved these changes

@ankudinov ankudinov Awaiting requested review from ankudinov

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
type: Python filters
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
4 participants
@ClausHolbechArista @KonikaChaurasiya-GSLab @tgodaA @carlbuchmann