Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_cli_config_gen): dns config reorder #1589

Merged
merged 1 commit into from
Mar 16, 2022
Merged

Fix(eos_cli_config_gen): dns config reorder #1589

merged 1 commit into from
Mar 16, 2022

Conversation

ryanmerolle
Copy link
Contributor

@ryanmerolle ryanmerolle commented Mar 15, 2022 •
edited
Loading

Change Summary

DNS config order/consolidation

Related Issue(s)

Fixes #1572

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Similar to the other #1572 related PRs, this focuses on the order and config output to match closer to how EOS generates said config

How to test

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ryanmerolle ryanmerolle requested a review from a team as a code owner March 15, 2022 21:44
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels Mar 15, 2022
@ryanmerolle ryanmerolle mentioned this pull request Mar 15, 2022
Closed
12 tasks
ClausHolbechArista
ClausHolbechArista approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Verified on DUT

@ankudinov ankudinov self-requested a review March 16, 2022 09:48
ankudinov
ankudinov approved these changes Mar 16, 2022
View reviewed changes
Copy link
Contributor

@ankudinov ankudinov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM and tested on DUT

@ClausHolbechArista ClausHolbechArista merged commit ef55877 into aristanetworks:devel Mar 16, 2022
@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): dns config consolidation Fix(eos_cli_config_gen): dns config reorder Mar 16, 2022
@ryanmerolle ryanmerolle deleted the feat_1572_dns_order branch March 16, 2022 19:26
@carlbuchmann carlbuchmann added this to the v3.4.0 milestone Apr 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@ankudinov ankudinov ankudinov approved these changes

Assignees

@ryanmerolle ryanmerolle

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): Order config output closer to EOS config order
4 participants
@ryanmerolle @ankudinov @ClausHolbechArista @carlbuchmann