Refactor(eos_cli_config_gen): Wildcard dict to list for ip_extcommunity_lists #1602
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
KonikaChaurasiya-GSLab
force-pushed
the
eos_cli_config_gen/dict2list/ip-extended-community-lists
branch
from
57cff11
to
9913c6f
Compare
github-actions
bot
added
the
state: CI Updated
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
…ty_lists after convertDict filter code change
ClausHolbechArista
approved these changes
Apr 22, 2022
ansible_collections/arista/avd/roles/eos_cli_config_gen/README_v4.0.md
Outdated
Show resolved
Hide resolved
...s/arista/avd/roles/eos_cli_config_gen/templates/documentation/ip-extended-community-lists.j2
Outdated
Show resolved
Hide resolved
...collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ip-extended-community-lists.j2
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Wildcard Keyed Dict" to "List of Dicts" Data model migration
Data model key
ip_extcommunity_listsChecklist
Contributor Checklist
README_v4.0.mdwith new data modelhost_varsunder molecule scenarioeos_cli_config_gen_v4.0with new data modeltemplates/eos/< template >.j2andtemplates/documentation/< template >.j2:arista.avd.convert_dicts('<primary key>')filter for loops previously using wildcard keysarista.avd.natural_sort('<primary key>')to sort on the primary key (if applicable)cd ansible_collections/arista/avd/molecule ; make cli-4.0-schemaReviewer Checklist
Reviewer 1: Claus
host_varsundereos_cli_config_gen_v4.0has been updated to the new data modelReviewer 2: Tony
host_varsundereos_cli_config_gen_v4.0has been updated to the new data model