Refactor(eos_designs): Set peer facts per device instead of shared #1614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Set peer facts per device instead of shared
Component(s) name
arista.avd.eos_designsProposed changes
Ansible set facts on all devices when using
set_factoryaml_templates_to_factsin combination withrun_onceand not usingdelegate_to.This was not clear to me, when writing the original implementation of peer facts, so this PR simplifies the playbook and code a bit, by leveraging this behavior.
How to test
No changes to any output
I have not been able to see any change to runtime, but welcome test results from others. (Run it a few times with devel vs this one and compare)
Checklist
User Checklist
Repository Checklist