Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor(eos_cli_config_gen): Use arista.avd.defined filter in hardware_counters.j2 #1630

Merged
merged 1 commit into from
Mar 25, 2022
Merged

Refactor(eos_cli_config_gen): Use arista.avd.defined filter in hardware_counters.j2 #1630

merged 1 commit into from
Mar 25, 2022

Conversation

Shivani-chourasiya
Copy link
Contributor

@Shivani-chourasiya Shivani-chourasiya commented Mar 25, 2022 •
edited by carlbuchmann
Loading

Change Summary

Use arista.avd.defined filter in hardware_counters.j2

Component(s) name

arista.avd.eos_cli_config_gen

How to test

See Molecule results

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@Shivani-chourasiya Shivani-chourasiya requested a review from a team as a code owner March 25, 2022 10:38
@Shivani-chourasiya Shivani-chourasiya marked this pull request as draft March 25, 2022 10:39
@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Mar 25, 2022
@Shivani-chourasiya Shivani-chourasiya changed the title Refactor(eos_cli_config_gen):Added avd defined filter in hardware_counters.j2 Refactor(eos_cli_config_gen): Added avd defined filter in hardware_counters.j2 Mar 25, 2022
@ClausHolbechArista ClausHolbechArista changed the title Refactor(eos_cli_config_gen): Added avd defined filter in hardware_counters.j2 Fix(eos_cli_config_gen): Add missing variable protection in hardware_counters.j2 Mar 25, 2022
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_cli_config_gen): Add missing variable protection in hardware_counters.j2 Refactor(eos_cli_config_gen): Use arista.avd.defined filter in hardware_counters.j2 Mar 25, 2022
ClausHolbechArista
ClausHolbechArista approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks

tgodaA
tgodaA approved these changes Mar 25, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann marked this pull request as ready for review March 25, 2022 22:35
@carlbuchmann carlbuchmann self-requested a review March 25, 2022 22:36
carlbuchmann
carlbuchmann approved these changes Mar 25, 2022
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 9d8e4bf into aristanetworks:devel Mar 25, 2022
@carlbuchmann carlbuchmann added this to the v3.4.0 milestone Apr 1, 2022
@Shivani-chourasiya Shivani-chourasiya deleted the hardware_couters branch August 29, 2022 10:27
@Shivani-chourasiya Shivani-chourasiya removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees
No one assigned
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role
Projects
None yet
Milestone
v3.4.0
Development

Successfully merging this pull request may close these issues.
5 participants
@Shivani-chourasiya @carlbuchmann @ClausHolbechArista @tgodaA @Shivani-gslab