Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_cli_config_gen): Wildcard dict to list for interface-groups #1644

Merged

Conversation

Shivani-chourasiya
Copy link
Contributor

@Shivani-chourasiya Shivani-chourasiya commented Mar 29, 2022

"Wildcard Keyed Dict" to "List of Dicts" Data model migration

Data model key

interface-groups

Checklist

Contributor Checklist

  • Update README_v4.0.md with new data model
  • Update all host_vars under molecule scenario eos_cli_config_gen_v4.0 with new data model
  • Update templates/eos/< template >.j2 and templates/documentation/< template >.j2:
    • Add arista.avd.convert_dicts('<primary key>') filter for loops previously using wildcard keys
    • Update arista.avd.natural_sort('<primary key>') to sort on the primary key (if applicable)
  • Run molecule cd ansible_collections/arista/avd/molecule ; make cli-4.0-schema
    • Verify no changes to generated configs/docs

Reviewer Checklist

  • Reviewer 1: Claus

    • Verify data model changes
    • Verify that all molecule host_vars under eos_cli_config_gen_v4.0 has been updated to the new data model
    • Verify no changes to configs/docs on any molecule scenario
    • Verify that CI pass
  • Reviewer 2: Tony

    • Verify data model changes
    • Verify that all molecule host_vars under eos_cli_config_gen_v4.0 has been updated to the new data model
    • Verify no changes to configs/docs on any molecule scenario
    • Verify that CI pass

@Shivani-chourasiya Shivani-chourasiya requested a review from a team as a code owner March 29, 2022 11:52
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Mar 29, 2022
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 134d683 into aristanetworks:devel Mar 30, 2022
@carlbuchmann carlbuchmann added this to the v3.4.0 milestone Apr 1, 2022
@Shivani-chourasiya Shivani-chourasiya deleted the interface_groups branch August 29, 2022 10:27
@Shivani-chourasiya Shivani-chourasiya removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
EPIC - AVD Schema role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants