Refactor(eos_cli_config_gen): Wildcard dict to list for port-channel-interfaces #1665
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
Shivani-chourasiya
force-pushed
the
port_channel_interfaces
branch
2 times, most recently
from
3948de0 to
29eb13f
Compare
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
tgodaA
reviewed
Apr 7, 2022
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
tgodaA
reviewed
Apr 7, 2022
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
tgodaA
reviewed
Apr 7, 2022
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
tgodaA
reviewed
Apr 7, 2022
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ethernet-interfaces.j2
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
port_channel_interfaces
branch
from
c2ac056 to
63a31d9
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
...tions/arista/avd/molecule/eos_designs_unit_tests/documentation/devices/core-1-isis-sr-ldp.md
Outdated
Show resolved
Hide resolved
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
ClausHolbechArista
force-pushed
the
port_channel_interfaces
branch
from
223fe81 to
c330dcf
Compare
|
Conflicts have been resolved. A maintainer will review the pull request shortly. |
ClausHolbechArista
force-pushed
the
port_channel_interfaces
branch
from
c330dcf to
6b016ce
Compare
ClausHolbechArista
approved these changes
Apr 25, 2022
tgodaA
reviewed
Apr 26, 2022
...llections/arista/avd/roles/eos_cli_config_gen/templates/documentation/ethernet-interfaces.j2
Outdated
Show resolved
Hide resolved
tgodaA
reviewed
Apr 26, 2022
| | {{ port_channel_interface }} | {{ description }} | {{ type }} | {{ mlag }} | {{ ipv6_address }} | {{ vrf }} | {{ mtu }} | {{ shutdown | lower }} | {{ ipv6_nd_ra_disabled | lower }} | {{ ipv6_nd_managed_config_flag | lower }} | {{ ipv6_acl_in }} | {{ ipv6_acl_out }} | | ||
| {% set ipv6_acl_in = port_channel_interface.ipv6_access_group_in | arista.avd.default("-") %} | ||
| {% set ipv6_acl_out = port_channel_interface.ipv6_access_group_out | arista.avd.default("-") %} | ||
| | {{ port_channel_interface.name }} | {{ description }} | {{ type }} | {{ mlag }} | {{ ipv6_address }} | {{ vrf }} | {{ mtu }} | {{ shutdown | lower }} | {{ ipv6_nd_ra_disabled | lower }} | {{ ipv6_nd_managed_config_flag | lower }} | {{ ipv6_acl_in }} | {{ ipv6_acl_out }} | |
There was a problem hiding this comment.
Need to fix this lower filter on boolean in separate PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
"Wildcard Keyed Dict" to "List of Dicts" Data model migration
Data model key
port-channel-interfacesChecklist
Contributor Checklist
README_v4.0.mdwith new data modelhost_varsunder molecule scenarioeos_cli_config_gen_v4.0with new data modeltemplates/eos/< template >.j2andtemplates/documentation/< template >.j2:arista.avd.convert_dicts('<primary key>')filter for loops previously using wildcard keysarista.avd.natural_sort('<primary key>')to sort on the primary key (if applicable)cd ansible_collections/arista/avd/molecule ; make cli-4.0-schemaReviewer Checklist
Reviewer 1: Claus
host_varsundereos_cli_config_gen_v4.0has been updated to the new data modelReviewer 2: Tony
host_varsundereos_cli_config_gen_v4.0has been updated to the new data model