-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(plugins): Updated convert_dicts filter for list values in dictionary #1694
Merged
ClausHolbechArista
merged 3 commits into
aristanetworks:devel
from
Shivani-chourasiya:convert_dicts
Apr 19, 2022
Merged
Feat(plugins): Updated convert_dicts filter for list values in dictionary #1694
ClausHolbechArista
merged 3 commits into
aristanetworks:devel
from
Shivani-chourasiya:convert_dicts
Apr 19, 2022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
type: Python filters
labels
Apr 8, 2022
Shivani-chourasiya
changed the title
Feat(convert_dicts filter): Updated convert_dicts filter for list values in dictionary
Feat(convert_dicts): Updated convert_dicts filter for list values in dictionary
Apr 8, 2022
Shivani-chourasiya
changed the title
Feat(convert_dicts): Updated convert_dicts filter for list values in dictionary
Feat(plugins): Updated convert_dicts filter for list values in dictionary
Apr 8, 2022
ClausHolbechArista
requested changes
Apr 11, 2022
...sta/avd/molecule/eos_cli_config_gen_v4.0/inventory/host_vars/ip-extended-community-lists.yml
Outdated
Show resolved
Hide resolved
Shivani-chourasiya
force-pushed
the
convert_dicts
branch
2 times, most recently
from
April 12, 2022 10:44
6547f56
to
184d606
Compare
Shivani-chourasiya
force-pushed
the
convert_dicts
branch
from
April 12, 2022 10:46
184d606
to
d0bd996
Compare
Shivani-chourasiya
force-pushed
the
convert_dicts
branch
from
April 13, 2022 12:59
d4e174c
to
04dcd3d
Compare
ClausHolbechArista
approved these changes
Apr 13, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Shivani-chourasiya
force-pushed
the
convert_dicts
branch
2 times, most recently
from
April 14, 2022 07:02
dc4d88b
to
5f4bce2
Compare
Shivani-chourasiya
force-pushed
the
convert_dicts
branch
from
April 14, 2022 07:18
5f4bce2
to
43ba962
Compare
KonikaChaurasiya-GSLab
approved these changes
Apr 14, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
role: eos_cli_config_gen
issue related to eos_cli_config_gen role
state: CI Updated
CI scenario have been updated in the PR
state: Documentation role Updated
type: Python filters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Updated convert_dicts filter for list values in dictionary
Related Issue(s)
Some of the data models have list of dictionaries inside nested dictionary, for which we need to introduce a new key in the data model schema and templates of eos_cli_config_gen_v4.0 , which is affecting molecule execution of older templates(eos_cli_config_gen) as the key is not found.
Example:
OLD
NEW
Component(s) name
arista.avd.convert_dicts
Proposed changes
Checks if the nested dictionary value is list, a new key (secondary_key) will be inserted in the inner dictionary.
How to test
The update to ip_extcommunity_lists.yml in this PR will fail with the older code.
Checklist
User Checklist
Repository Checklist