Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs, eos_cli_config_gen): Support default-services in management-api-http #1704

Merged
merged 2 commits into from
Apr 19, 2022
Merged

Feat(eos_designs, eos_cli_config_gen): Support default-services in management-api-http #1704

merged 2 commits into from
Apr 19, 2022

Conversation

tgodaA
Copy link
Contributor

@tgodaA tgodaA commented Apr 9, 2022

Change Summary

Support the default-services option in management-api-http services.

Component(s) name

arista.avd.eos_designs, arista.avd.eos_cli_config_gen

Proposed changes

  1. eos_designs
management_eapi:
  default_services: < boolean >
  1. eos_cli_config_gen
management_api_http:
  default_services: < boolean >

How to test

Molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@tgodaA tgodaA requested a review from a team as a code owner April 9, 2022 17:21
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Apr 9, 2022
ClausHolbechArista
ClausHolbechArista approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

emilarista
emilarista approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 4231e40 into aristanetworks:devel Apr 19, 2022
@tgodaA tgodaA deleted the mgmt_http branch April 20, 2022 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@emilarista emilarista emilarista approved these changes

Assignees

@tgodaA tgodaA

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgodaA @ClausHolbechArista @emilarista