Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): VRRP timer delay and IPv4 version options #1706

Merged
merged 3 commits into from
Apr 21, 2022
Merged

Feat(eos_cli_config_gen): VRRP timer delay and IPv4 version options #1706

merged 3 commits into from
Apr 21, 2022

Conversation

c-po
Copy link
Contributor

@c-po c-po commented Apr 11, 2022 •
edited
Loading

Change Summary

Add support for VRRP timer delay reload command per VRID

Related Issue(s)

Fixes #1705

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

# New improved "vrrp" data model to support multiple IDs
vrrp_ids:
  - id: < vrid >
    timers:
      delay:
        reload: < integer >

How to test

Molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@c-po c-po requested a review from a team as a code owner April 11, 2022 09:32
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Apr 11, 2022
@ClausHolbechArista
Copy link
Contributor

I just merged PR 1637 which also includes documentation for VRRP groups. Please add documentation for the new knobs as applicable.

@github-actions github-actions bot added the state: conflict PR with conflict label Apr 11, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@c-po
Copy link
Contributor Author

c-po commented Apr 11, 2022

@ClausHolbechArista should I simply add a column to indicate if timers are configured like preempt?

@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label Apr 11, 2022
@ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista should I simply add a column to indicate if timers are configured like preempt?

To not overdo it, maybe just add the version to the table.

ClausHolbechArista
ClausHolbechArista approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista changed the title Feat(eos_cli_config_gen): VRRP timer delay and IPv4 version CLI options Feat(eos_cli_config_gen): VRRP timer delay and IPv4 version options Apr 19, 2022
@ClausHolbechArista ClausHolbechArista requested a review from a team April 20, 2022 07:57
emilarista
emilarista approved these changes Apr 21, 2022
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@ClausHolbechArista ClausHolbechArista merged commit 675b1c5 into aristanetworks:devel Apr 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@emilarista emilarista emilarista approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@c-po c-po

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_cli_config_gen): VRRP timer delay and IPv4 version CLI options
3 participants
@c-po @ClausHolbechArista @emilarista