Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Various galaxy-importer issues #1718

Merged
merged 2 commits into from
Apr 15, 2022
Merged

Fix: Various galaxy-importer issues #1718

merged 2 commits into from
Apr 15, 2022

Conversation

ClausHolbechArista
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista commented Apr 13, 2022 •
edited
Loading

Change Summary

Fix: Various galaxy-importer issues

Proposed changes

Change ignore_errors to failed_when

How to test

CI will rerun galaxy-importer, so we can check if errors/warnings dissappears.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner April 13, 2022 11:56
@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Apr 13, 2022
@github-actions github-actions bot added role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role role: eos_config_deploy_eapi issue related to eos_config_deploy_eapi role role: eos_designs issue related to eos_designs role role: eos_snapshot role: eos_validate_state labels Apr 13, 2022
carlbuchmann
carlbuchmann approved these changes Apr 15, 2022
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 93381e3 into aristanetworks:devel Apr 15, 2022
@ClausHolbechArista ClausHolbechArista deleted the Fix--Various-galaxy-importer-issues branch December 22, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@ClausHolbechArista ClausHolbechArista

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role role: eos_config_deploy_eapi issue related to eos_config_deploy_eapi role role: eos_designs issue related to eos_designs role role: eos_snapshot role: eos_validate_state
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ClausHolbechArista @carlbuchmann