Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): dot1x-pae-mode #1722

Merged
merged 12 commits into from
Apr 20, 2022
Merged

Feat(eos_cli_config_gen): dot1x-pae-mode #1722

merged 12 commits into from
Apr 20, 2022

Conversation

mthiel117
Copy link
Contributor

@mthiel117 mthiel117 commented Apr 13, 2022 •
edited
Loading

Change Summary

Requires PR# 1700 to be merged first

Add Feature for 802.1X Pae Mode Authenticator

interface Ethernet33
   dot1x pae authenticator

Data Model:

dot1x:
  pae:
    mode: < "authenticator" >

Related Issue(s)

n/a

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

New feature to enable dot1x pae mode for authenticator.

How to test

Added molecule test scenario:

Ethernet33:
  description: DOT1X Testing - pae mode authenticator
  dot1x:
    pae:
      mode: "authenticator"

and then ran

molecule converge -s eos_cli_config_gen -- --limit ethernet-interfaces

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Apr 13, 2022
@mthiel117 mthiel117 changed the title Dot1x pae mode Feat(eos_cli_config_gen): dot1x-pae-mode Apr 13, 2022
@mthiel117 @ClausHolbechArista
Feat(eos_cli_config_gen): dot1x-reauthentication (aristanetworks#1700)
83025d9 
Co-authored-by: Claus Holbech <holbech@arista.com>
@github-actions github-actions bot added the state: conflict PR with conflict label Apr 14, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the state: conflict PR with conflict label Apr 14, 2022
@github-actions
Copy link

Conflicts have been resolved. A maintainer will review the pull request shortly.

@mthiel117 mthiel117 marked this pull request as ready for review April 14, 2022 14:15
@mthiel117 mthiel117 requested a review from a team as a code owner April 14, 2022 14:15
ClausHolbechArista
ClausHolbechArista approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team April 19, 2022 12:33
tgodaA
tgodaA approved these changes Apr 19, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit ec5684d into aristanetworks:devel Apr 20, 2022
@mthiel117 mthiel117 deleted the dot1x-pae-mode branch April 20, 2022 11:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@tgodaA tgodaA tgodaA approved these changes

Assignees

@mthiel117 mthiel117

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mthiel117 @ClausHolbechArista @tgodaA