Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Add EngineID support to snmp-settings #1725

Closed
wants to merge 1 commit into from

Conversation

ccsnw
Copy link
Contributor

@ccsnw ccsnw commented Apr 19, 2022

Change Summary

Add options to configure remote and local EngineIDs in SNMP Settings

Related Issue(s)

Fixes #<N/A>

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Allow to configure:

  • Local EngineID
  • Remote EngineID(s)
snmp_server:
<snip>
  engine_ids:
    - type: < local | remote >
      name: < engine_name in hex >
      ip: < hostname | ip of remote engine >
      port: < udp-port of remote engine >
</snip>

How to test

Modified molecule test to include local and remote ID's

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ccsnw ccsnw requested a review from a team as a code owner April 19, 2022 09:15
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Apr 19, 2022
@ClausHolbechArista
Copy link
Contributor

This collides with #1721. Please comment on that one with your changes.

@ccsnw
Copy link
Contributor Author

ccsnw commented Apr 19, 2022

This collides with #1721. Please comment on that one with your changes.

Hi Claus,
Unfortunately I haven't noticed the other PR before.
My PR only allows to set a local and (n) remote engineIDs so far, but I have another PR prepared that would allow for the hashing using the local engine ID.

Let me add comments to the other PR and close mine.

@ccsnw ccsnw closed this Apr 19, 2022
@ccsnw ccsnw deleted the snmpsettings branch May 9, 2022 13:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants