Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_cli_config_gen): Extend listen_range support for BGP #1735

Merged
merged 7 commits into from
May 9, 2022

Conversation

ccsnw
Copy link
Contributor

@ccsnw ccsnw commented Apr 21, 2022

Change Summary

  • Allow user to configure multiple BGP listen_ranges with different kinds of filters
  • Moved this to general BGP settings (this is also where EOS cli places the output)

Related Issue(s)

Fixes #N/A

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

router_bgp:
  listen_ranges:
    - prefix: < A.B.C.D/E | A:B:C:D:E:F:G:H/I >
      # include router id as part of peer filter
      peer_id_include_router_id: < true | false >
      peer_group: < name of peer-group >
      # peer_filter and remote_as are mutally exclusive. if defined, peer_filter takes precedence
      peer_filter: < name of peer-filter >
      remote_as: < remote ASN in plain or dot notation >

How to test

Molecule tests added.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Apr 21, 2022
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have a large refactor PR for BGP templates in the works. We can still prepare this in parallel, but I will hold this one back until the refactor PR has been merged. Keep it in draft. Thanks.

  • Missing documentation template (add a new table)

@ccsnw
Copy link
Contributor Author

ccsnw commented Apr 21, 2022

We have a large refactor PR for BGP templates in the works. We can still prepare this in parallel, but I will hold this one back until the refactor PR has been merged. Keep it in draft. Thanks.

  • Missing documentation template (add a new table)

Will do!

@ccsnw
Copy link
Contributor Author

ccsnw commented Apr 22, 2022

We have a large refactor PR for BGP templates in the works. We can still prepare this in parallel, but I will hold this one back until the refactor PR has been merged. Keep it in draft. Thanks.

  • Missing documentation template (add a new table)

Documentation template added for review @ClausHolbechArista

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Keep it as draft until we are done with the refactor.

@ClausHolbechArista ClausHolbechArista marked this pull request as ready for review May 4, 2022 17:35
@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner May 4, 2022 17:35
@ClausHolbechArista
Copy link
Contributor

@ccsnw We are ready to take this now. Please rebase and fix accordingly. We have changed the nested dictionaries to be lists of dictionaries for this template (no required change to input model).

@ClausHolbechArista ClausHolbechArista dismissed their stale review May 4, 2022 17:37

will do a new review after rebase

@github-actions
Copy link

github-actions bot commented May 4, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the state: conflict PR with conflict label May 4, 2022
@ccsnw
Copy link
Contributor Author

ccsnw commented May 5, 2022

@ccsnw We are ready to take this now. Please rebase and fix accordingly. We have changed the nested dictionaries to be lists of dictionaries for this template (no required change to input model).

Thanks! On it

@github-actions
Copy link

github-actions bot commented May 5, 2022

Conflicts have been resolved. A maintainer will review the pull request shortly.

@github-actions github-actions bot removed the state: conflict PR with conflict label May 5, 2022
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit df02955 into aristanetworks:devel May 9, 2022
@ccsnw ccsnw deleted the listenrange branch May 9, 2022 13:13
ccsnw added a commit to ccsnw/ansible-avd that referenced this pull request May 10, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants