-
Notifications
You must be signed in to change notification settings - Fork 235
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_cli_config_gen): Extend listen_range support for BGP #1735
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have a large refactor PR for BGP templates in the works. We can still prepare this in parallel, but I will hold this one back until the refactor PR has been merged. Keep it in draft. Thanks.
- Missing documentation template (add a new table)
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
Outdated
Show resolved
Hide resolved
Will do! |
ansible_collections/arista/avd/roles/eos_cli_config_gen/templates/eos/router-bgp.j2
Outdated
Show resolved
Hide resolved
Documentation template added for review @ClausHolbechArista |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Keep it as draft until we are done with the refactor.
@ccsnw We are ready to take this now. Please rebase and fix accordingly. We have changed the nested dictionaries to be lists of dictionaries for this template (no required change to input model). |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
Thanks! On it |
Conflicts have been resolved. A maintainer will review the pull request shortly. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Change Summary
Related Issue(s)
Fixes #N/A
Component(s) name
arista.avd.eos_cli_config_gen
Proposed changes
How to test
Molecule tests added.
Checklist
User Checklist
Repository Checklist