Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CI: Fix fabric_name in eos_designs_unit_tests molecule scenario #1755

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

CI: Fix fabric_name in eos_designs_unit_tests molecule scenario

Related Issue(s)

Currently we have 3 different fabric_name vars in this molecule scenario. This makes the fabric documentation fail or produce changes depending on which host is selected for "run_once".
This will also block the new avd_facts module, where we set facts for all devices in the same fabric_name group

Proposed changes

  • Move all existing groups down under a new parent group and set a common fabric_name on this parent group_vars.
  • Remove fabric_name from all other group_vars.

How to test

Molecule will produce changes to various descriptions and docs where the fabric_name is included.

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@ClausHolbechArista ClausHolbechArista requested a review from a team as a code owner May 2, 2022 16:01
@github-actions github-actions bot added the state: CI Updated CI scenario have been updated in the PR label May 2, 2022
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit 7a95be5 into aristanetworks:devel May 2, 2022
@ClausHolbechArista ClausHolbechArista deleted the fix-eos-designs-unit-tests-fabric-name branch December 22, 2022 07:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants