Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Support for multiple VARPv6 addresses #1761

Merged
merged 7 commits into from
May 9, 2022
Merged

Feat(eos_cli_config_gen): Support for multiple VARPv6 addresses #1761

merged 7 commits into from
May 9, 2022

Conversation

onurgashi
Copy link
Contributor

@onurgashi onurgashi commented May 4, 2022 •
edited
Loading

Change Summary

interface_vlan:
...
    # The below "VARPv6" keys will be deprecated in AVD v4.0 - These should not be mixed with the new "VARPv6" key above to avoid conflicts.
    ipv6_virtual_router_address: < IPv6_address >
    # New improved "VARPv6" data model to support multiple VARPv6 addresses.
    ipv6_virtual_router_address:
      - < IPv6_address/Mask | IPv6_address >
      - < IPv6_address/Mask | IPv6_address >

Related Issue(s)

Fixes the data model to support multiple VARPv6 addresses on a VLAN interface

Component(s) name

arista.avd.cli_config_gen

Proposed changes

How to test

Molecule eos_cli_config_gen

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@onurgashi onurgashi added type: bug Something isn't working role: eos_cli_config_gen issue related to eos_cli_config_gen role data model change Change to existing data model labels May 4, 2022
@onurgashi onurgashi self-assigned this May 4, 2022
@onurgashi onurgashi requested a review from a team as a code owner May 4, 2022 09:02
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 4, 2022
@onurgashi onurgashi changed the title Varpv6 bug cli config gen VARPv6 data model change for multiple addresses May 4, 2022
@ClausHolbechArista ClausHolbechArista changed the title VARPv6 data model change for multiple addresses Feat(eos_cli_config_gen): Support for multiple VARPv6 addresses May 4, 2022
@ClausHolbechArista ClausHolbechArista removed the type: bug Something isn't working label May 9, 2022
ClausHolbechArista
ClausHolbechArista approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team May 9, 2022 16:57
tgodaA
tgodaA approved these changes May 9, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodaA tgodaA merged commit 383115d into aristanetworks:devel May 9, 2022
ccsnw pushed a commit to ccsnw/ansible-avd that referenced this pull request May 10, 2022
@onurgashi @ClausHolbechArista @ccsnw
Feat(eos_cli_config_gen): Support for multiple VARPv6 addresses (aris…
8e120d4 
…tanetworks#1761)

Co-authored-by: Claus Holbech <holbech@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA approved these changes

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

Assignees

@onurgashi onurgashi

Labels
data model change Change to existing data model role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@onurgashi @ClausHolbechArista @tgodaA