CI: Add molecule scenario eos_designs_unit_tests_v4.0 for testing refactored eos_designs data models
#1762
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
role: eos_designs
carlbuchmann
approved these changes
May 6, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Add molecule scenario
eos_designs_unit_tests_v4.0for testing refactored eos_designs data modelsComponent(s) name
arista.avdProposed changes
To prepare for refactoring of
eos_designswildcard-dict to lists, we will add a moleculescenario with disabled convertion, so the role templates can be tested with the new data models.
Notice that this molecule scenario will not render configs or device documentation. To prevent the automatic conversion, this molecule scenario run with the environment
variable "AVD_DISABLE_CONVERT_DICTS=TRUE" which disables the conversion.
Until eos_designs output has been changed to lists of dictionaries, we can not run
eos_cli_config_gen role, since it would also pick up the environment variable, hence
disabling conversion.
The molecule scenario has been updated with the data models which has already been converted
over the last period.
How to test
To ensure no changes to the molecule output, I have included a comparison of all structured configs between
eos_designs_unit_testsandeos_designs_unit_tests_v4.0:holbech@holbech:~/ansible-avd/ansible_collections/arista/avd/molecule$ diff eos_designs_unit_tests/intended/structured_configs/ eos_designs_unit_tests_v4.0/intended/structured_configs/ -s Files eos_designs_unit_tests/intended/structured_configs/core-1-isis-sr-ldp.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/core-1-isis-sr-ldp.yml are identical Files eos_designs_unit_tests/intended/structured_configs/core-2-ospf-ldp.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/core-2-ospf-ldp.yml are identical Files eos_designs_unit_tests/intended/structured_configs/cvp-instance-ips-cvaas.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/cvp-instance-ips-cvaas.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-BL1A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-BL1A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-BL1B.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-BL1B.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-BL2A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-BL2A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-BL2B.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-BL2B.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-CL1A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-CL1A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-CL1B.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-CL1B.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-L2LEAF1A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-L2LEAF1A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-L2LEAF1B.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-L2LEAF1B.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-L2LEAF2A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-L2LEAF2A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-L2LEAF2B.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-L2LEAF2B.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-L2LEAF3A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-L2LEAF3A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-L2LEAF4A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-L2LEAF4A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-L2LEAF5A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-L2LEAF5A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-L2LEAF5B.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-L2LEAF5B.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-LEAF1A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-LEAF1A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-LEAF2A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-LEAF2A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-LEAF2B.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-LEAF2B.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-SPINE1.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-SPINE1.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-SPINE2.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-SPINE2.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-SPINE3.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-SPINE3.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-SPINE4.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-SPINE4.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-SVC3A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-SVC3A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/DC1-SVC3B.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/DC1-SVC3B.yml are identical Files eos_designs_unit_tests/intended/structured_configs/evpn_services_l2_only_false.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/evpn_services_l2_only_false.yml are identical Files eos_designs_unit_tests/intended/structured_configs/evpn_services_l2_only_true.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/evpn_services_l2_only_true.yml are identical Files eos_designs_unit_tests/intended/structured_configs/mgmt_interface_default.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/mgmt_interface_default.yml are identical Files eos_designs_unit_tests/intended/structured_configs/mgmt_interface_fabric.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/mgmt_interface_fabric.yml are identical Files eos_designs_unit_tests/intended/structured_configs/mgmt_interface_host.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/mgmt_interface_host.yml are identical Files eos_designs_unit_tests/intended/structured_configs/mgmt_interface_platform.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/mgmt_interface_platform.yml are identical Files eos_designs_unit_tests/intended/structured_configs/MH-L2LEAF1A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/MH-L2LEAF1A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/MH-LEAF1A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/MH-LEAF1A.yml are identical Files eos_designs_unit_tests/intended/structured_configs/MH-LEAF1B.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/MH-LEAF1B.yml are identical Files eos_designs_unit_tests/intended/structured_configs/MH-LEAF2A.yml and eos_designs_unit_tests_v4.0/intended/structured_configs/MH-LEAF2A.yml are identicalChecklist
User Checklist
Repository Checklist