Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): BGP VRF IPv4 RM support #1763

Merged
merged 4 commits into from
May 12, 2022
Merged

Feat(eos_cli_config_gen): BGP VRF IPv4 RM support #1763

merged 4 commits into from
May 12, 2022

Conversation

danieltudares
Copy link
Contributor

Feat(eos_cli_config_gen): BGP VRF IPv4 RM support

Change Summary

Support AVD data model for BGP VRF address-family IPv4 Route-maps

Related Issue(s)

Fixes #1756

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Support for knob to apply route maps (in/out) under router_bgp > vrfs > address_families > neighbor :

router_bgp:
  vrfs:
    <vrf>:
      address_families:
        < address_family >:
          neighbors:
            < neighbor_ip_address >:
              route_map_out: < route-map name >
              route_map_in: < route-map name >

How to test

molecule

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@danieltudares danieltudares requested a review from a team as a code owner May 5, 2022 14:50
@danieltudares danieltudares self-assigned this May 5, 2022
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR labels May 5, 2022
@danieltudares danieltudares mentioned this pull request May 5, 2022
Closed
4 tasks
gmuloc
gmuloc reviewed May 10, 2022
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just a couple of minor names to change in READMEs to match (most of) the other README indications

ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md Outdated Show resolved Hide resolved
ansible_collections/arista/avd/roles/eos_cli_config_gen/README_v4.0.md Outdated Show resolved Hide resolved
danieltudares and others added 2 commits May 10, 2022 08:50
@danieltudares @gmuloc
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/README.md
1b51056 
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@danieltudares @gmuloc
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/README…
22bc873 
…_v4.0.md

Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
@danieltudares danieltudares requested review from gmuloc and a team May 10, 2022 13:42
gmuloc
gmuloc approved these changes May 11, 2022
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ClausHolbechArista
ClausHolbechArista approved these changes May 12, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit a79ae0d into aristanetworks:devel May 12, 2022
@danieltudares danieltudares deleted the dtudares-bgp-vrf-af-rm branch May 12, 2022 13:03
jonxstill pushed a commit to jonxstill/ansible-avd that referenced this pull request May 31, 2022
@danieltudares @gmuloc @jonxstill
Feat(eos_cli_config_gen): BGP VRF IPv4 RM support (aristanetworks#1763)
47e29a2 
Co-authored-by: Guillaume Mulocher <gmulocher@arista.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@danieltudares danieltudares

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

BGP VRF Address-Family IPv4 Route-map support
3 participants
@danieltudares @gmuloc @ClausHolbechArista