-
Notifications
You must be signed in to change notification settings - Fork 219
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Refactor(eos_designs): Wildcard dict to list management-settings event_handlers #1790
Refactor(eos_designs): Wildcard dict to list management-settings event_handlers #1790
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there not be a test for this to adapt / create in eos_designs
? (I could not find one so maybe need to create it)
yes ,I also didn't find it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should there not be a test for this to adapt / create in
eos_designs
? (I could not find one so maybe need to create it)yes ,I also didn't find it.
I discussed it with @ClausHolbechArista - I will add a PR with a test for this pre and post model change later
in the meantime LGTM!
"Wildcard Keyed Dict" to "List of Dicts" Data model migration
Data model key
event_handlers
Checklist
Contributor Checklist
README_v4.0.md
with new data modeltemplates/eos/< template >.j2
andtemplates/documentation/< template >.j2
:arista.avd.convert_dicts('<primary key>')
filter for loops previously using wildcard keysarista.avd.natural_sort('<primary key>')
to sort on the primary key (if applicable)Reviewer Checklist
Reviewer 1: (Claus)
Reviewer 2: (Guillaume)