Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor(eos_designs): Wildcard dict to list management-settings event_handlers #1790

Merged

Conversation

Shivani-chourasiya
Copy link
Contributor

@Shivani-chourasiya Shivani-chourasiya commented May 16, 2022

"Wildcard Keyed Dict" to "List of Dicts" Data model migration

Data model key

event_handlers

Checklist

Contributor Checklist

  • Update README_v4.0.md with new data model
  • Update templates/eos/< template >.j2 and templates/documentation/< template >.j2:
    • Add arista.avd.convert_dicts('<primary key>') filter for loops previously using wildcard keys
    • Update arista.avd.natural_sort('<primary key>') to sort on the primary key (if applicable)
  • Verify no changes to generated configs/docs

Reviewer Checklist

  • Reviewer 1: (Claus)

    • Verify data model changes
    • Verify no changes to configs/docs on any molecule scenario
    • Verify that CI pass
  • Reviewer 2: (Guillaume)

    • Verify data model changes
    • Verify no changes to configs/docs on any molecule scenario
    • Verify that CI pass

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there not be a test for this to adapt / create in eos_designs? (I could not find one so maybe need to create it)

@Shivani-chourasiya
Copy link
Contributor Author

Should there not be a test for this to adapt / create in eos_designs? (I could not find one so maybe need to create it)

yes ,I also didn't find it.

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should there not be a test for this to adapt / create in eos_designs? (I could not find one so maybe need to create it)

yes ,I also didn't find it.

I discussed it with @ClausHolbechArista - I will add a PR with a test for this pre and post model change later

in the meantime LGTM!

@ClausHolbechArista ClausHolbechArista merged commit b0531a7 into aristanetworks:devel May 16, 2022
jonxstill pushed a commit to jonxstill/ansible-avd that referenced this pull request May 31, 2022
@Shivani-chourasiya Shivani-chourasiya deleted the event_handlers branch August 29, 2022 10:28
@Shivani-chourasiya Shivani-chourasiya removed their assignment Sep 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants