Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): SBFD configuration under Router BFD and SR-TE policy #1802 #1808

Merged
merged 11 commits into from
Jun 27, 2022
Merged

Feat(eos_cli_config_gen): SBFD configuration under Router BFD and SR-TE policy #1802 #1808

merged 11 commits into from
Jun 27, 2022

Conversation

sengarth
Copy link
Contributor

@sengarth sengarth commented May 20, 2022 •
edited by tgodaA
Loading

Change Summary

Enable SBFD configuration under router bfd

router bfd
   sbfd
      local-interface Loopback0 ipv4 ipv6
      initiator interval 500 multiplier 3
      reflector min-rx 600
      reflector local-discriminator 155.1.3.1

Also enable SBFD under router traffic-engineering

router traffic-engineering
   segment-routing
      !
      policy endpoint 1.2.3.4 color 70810
         binding-sid 970810
         sbfd remote-discriminator 155.2.1.1

Related Issue(s)

Fixes #1802
#1872

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

Additional fields to render SBFD configuration in existing yaml for both feature sets.

router_bfd:
  sbfd:
    local_interface:
      name: Loopback0
      protocol: ipv4 ipv6
    initiator_interval: 500
    initiator_multiplier: 3
    reflector:
      min_rx: 600
      local_discriminator: 155.1.3.1
router_traffic_engineering:
  segment_routing:
    policy_endpoints:
        colors:
            sbfd_remote_discriminator: 155.2.1.1

How to test

molecule test --scenario-name eos_cli_config_gen

Checklist

User Checklist

  • No breaking changes

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@sengarth sengarth requested a review from a team as a code owner May 20, 2022 17:14
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels May 20, 2022
sengarth and others added 2 commits June 2, 2022 01:09
@sengarth @emilarista
Update ansible_collections/arista/avd/roles/eos_cli_config_gen/templa…
a2fb7bb 
…tes/eos/router-bfd.j2

Co-authored-by: emilarista <73955263+emilarista@users.noreply.github.com>
@sengarth
Empty commit to retrigger actions
6afb9eb
emilarista
emilarista approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@emilarista emilarista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@tgodaA tgodaA linked an issue Jun 24, 2022 that may be closed by this pull request
Add support for SBFD in traffic-engineering in config_gen #1872
Closed
1 task
ClausHolbechArista
ClausHolbechArista approved these changes Jun 27, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit dbb459c into aristanetworks:devel Jun 27, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@emilarista emilarista emilarista approved these changes

@tgodaA tgodaA Awaiting requested review from tgodaA

Assignees

@sengarth sengarth

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
4 participants
@sengarth @ClausHolbechArista @emilarista @tgodaA