Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix(eos_designs): Failure with OSPF underlay and mlag_peer_l3_vlan == mlag_peer_vlan #1842

Merged
merged 6 commits into from
Jun 9, 2022
Merged

Fix(eos_designs): Failure with OSPF underlay and mlag_peer_l3_vlan == mlag_peer_vlan #1842

merged 6 commits into from
Jun 9, 2022

Conversation

pvinci-arista
Copy link
Contributor

Change Summary

molecule test to demonstrate failure

Related Issue(s)

Fixes #1841

Component(s) name

arista.avd.eos_designs

Proposed changes

How to test

ANSIBLE_OPTIONS='-vvv' MOLECULE=eos_designs_unit_tests make run

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@pvinci-arista pvinci-arista requested a review from a team as a code owner June 1, 2022 23:25
@github-actions github-actions bot added state: CI Updated CI scenario have been updated in the PR role: eos_designs issue related to eos_designs role labels Jun 1, 2022
@pvinci-arista pvinci-arista changed the title Bug(eos_designs): playbook fails if mlag_peer_l3_vlan == mlag_peer_vlan Fix(eos_designs): playbook fails if mlag_peer_l3_vlan == mlag_peer_vlan Jun 1, 2022
@ClausHolbechArista ClausHolbechArista changed the title Fix(eos_designs): playbook fails if mlag_peer_l3_vlan == mlag_peer_vlan Fix(eos_designs): Failure with OSPF underlay and mlag_peer_l3_vlan == mlag_peer_vlan Jun 2, 2022
@tgodaA
Copy link
Contributor

tgodaA commented Jun 2, 2022

Please run the molecule once again for eos_designs_unit_tests.

gmuloc
gmuloc requested changes Jun 3, 2022
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you also add the test in the eos_designs_unit_tests_v4.0 once you have fixed the conflicting Ethernet interface?

...lections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/MLAG_OSPF_TESTS.yml Outdated Show resolved Hide resolved
@carlbuchmann
Copy link
Member

Can you also add the test in the eos_designs_unit_tests_v4.0 once you have fixed the conflicting Ethernet interface?

@gmuloc @pvinci-arista - note, that we don't need to update the eos_designs_unit_tests_v4.0 scenario at this time - we will merge them back into one scenario once we are done refactoring.

@gmuloc
Copy link
Contributor

gmuloc commented Jun 7, 2022

Can you also add the test in the eos_designs_unit_tests_v4.0 once you have fixed the conflicting Ethernet interface?

@gmuloc @pvinci-arista - note, that we don't need to update the eos_designs_unit_tests_v4.0 scenario at this time - we will merge them back into one scenario once we are done refactoring.

Noted! apologies for the comment

gmuloc
gmuloc approved these changes Jun 7, 2022
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

tgodaA
tgodaA approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodaA tgodaA merged commit 708abfc into aristanetworks:devel Jun 9, 2022
carlbuchmann added a commit to carlbuchmann/avd that referenced this pull request Jun 21, 2022
@pvinci-arista @ClausHolbechArista @carlbuchmann
Fix(eos_designs): Failure with OSPF underlay and mlag_peer_l3_vlan ==…
dba3111 
… mlag_peer_vlan (aristanetworks#1842)

Co-authored-by: Claus Holbech <holbech@arista.com>
Co-authored-by: Carl Buchmann <carl.buchmann@arista.com>
@carlbuchmann carlbuchmann mentioned this pull request Jun 21, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista left review comments

@carlbuchmann carlbuchmann carlbuchmann left review comments

@tgodaA tgodaA tgodaA approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@pvinci-arista pvinci-arista

Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Bug(eos_designs): playbook fails if mlag_peer_l3_vlan == mlag_peer_vlan
5 participants
@pvinci-arista @tgodaA @carlbuchmann @gmuloc @ClausHolbechArista