Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_designs): add support for 7300X3 in default platforms #1863

Merged
merged 2 commits into from
Jun 9, 2022
Merged

Feat(eos_designs): add support for 7300X3 in default platforms #1863

merged 2 commits into from
Jun 9, 2022

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jun 8, 2022

  • Move the default platform_settings variable to its own file for more
    clarity

Change Summary

add support for 7300X3 in default platforms

Related Issue(s)

Fixes #1860

Component(s) name

arista.avd.<role-name>

Proposed changes

  1. moved the default platforms settings to a separate file
  2. Add the following platform (no other list matching) 
    platform_settings:
  - platforms: ['7300X3']
    management_interface: Management0

How to test

reused one platform from eos_designs_unit_test molecule scenarios to test the settings

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc
Feat(eos_designs): add support for 7300X3 in default platforms
e92396a 
* Move the default platform_settings variable to its own file for more
  clarity
@gmuloc gmuloc requested a review from a team as a code owner June 8, 2022 12:23
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR labels Jun 8, 2022
jonxstill
jonxstill approved these changes Jun 8, 2022
View reviewed changes
Copy link
Contributor

@jonxstill jonxstill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me. Given that we're going to be making more use of this (see #1758 for my current piece of work, which I'm heavily refactoring now) and may have a proliferation of platforms, having a separate file is good. Also end users could then potentially use the combine filter to merge the defaults with their own platform-specific settings.

@gmuloc
Feat(eos_designs): add reload-delays based on platform default
7be08fd 
* platform default is 1200
* following the rest of the AVD platform settings, making non-mlag
  reload_delay bigger than mlag one.
xaviramon
xaviramon approved these changes Jun 9, 2022
View reviewed changes
Copy link
Contributor

@xaviramon xaviramon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodaA tgodaA merged commit 191c291 into aristanetworks:devel Jun 9, 2022
@gmuloc gmuloc deleted the issue/1860 branch November 21, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tgodaA tgodaA tgodaA left review comments

@jonxstill jonxstill jonxstill approved these changes

@xaviramon xaviramon xaviramon approved these changes

Assignees

@gmuloc gmuloc

Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Feat(eos_designs): support for 7300X platform
4 participants
@gmuloc @xaviramon @jonxstill @tgodaA