-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feat(eos_designs): Structured configuration support for uplink and mlag interfaces #1865
Feat(eos_designs): Structured configuration support for uplink and mlag interfaces #1865
Conversation
1941e72
to
ee04cdc
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's use a valid value for the native vlan test to not confuse the users
I have added a question regarding the order of precedence when you have structure_config existing in conjonction with these two new knobs as this is not clear for me. I think it should be documented + probably we should add some tests to verify that it works as we expect
...e_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_FABRIC.yml
Outdated
Show resolved
Hide resolved
...e_collections/arista/avd/molecule/eos_designs_unit_tests/inventory/group_vars/DC1_FABRIC.yml
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/molecule/eos_designs_unit_tests/intended/configs/DC1-SVC3B.cfg
Outdated
Show resolved
Hide resolved
ansible_collections/arista/avd/roles/eos_designs/doc/fabric-topology.md
Outdated
Show resolved
Hide resolved
ee04cdc
to
1367f61
Compare
1367f61
to
986cdde
Compare
ansible_collections/arista/avd/roles/eos_designs/doc/fabric-topology.md
Outdated
Show resolved
Hide resolved
for uplink and mlag interfaces
…pology.md Co-authored-by: Claus Holbech <holbech@arista.com>
…pology.md Co-authored-by: Claus Holbech <holbech@arista.com>
…pology.md Co-authored-by: Claus Holbech <holbech@arista.com>
…pology.md Co-authored-by: Claus Holbech <holbech@arista.com>
f6e924f
to
df78d79
Compare
Thank you @ClausHolbechArista - I've committed your suggestions! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
comment addressed in different PR.
Change Summary
Provide the ability to add structured configuration on uplink and mlag interface.
Component(s) name
arista.avd.eos_designs
Proposed changes
Structured configuration on uplink interfaces:
Structured configuration on mlag port-channel interface:
How to test
See molecule scenario
Checklist
Repository Checklist