Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat(eos_designs): Structured configuration support for uplink and mlag interfaces #1865

Conversation

carlbuchmann
Copy link
Member

@carlbuchmann carlbuchmann commented Jun 9, 2022

Change Summary

Provide the ability to add structured configuration on uplink and mlag interface.

Component(s) name

arista.avd.eos_designs

Proposed changes

Structured configuration on uplink interfaces:

### Uplink management

< node_type_key >:

    # Custom structured config applied to "uplink_interfaces", and "uplink_switch_interfaces"
    # When uplink_type == "p2p", custom structured config added under ethernet_interfaces.<interface> for eos_cli_config_gen
    # Overrides the settings on the ethernet interface level.
    # When uplink_type == "port-channel", custom structured config added under port_channel_interfaces.<interface> for eos_cli_config_gen
    # Overrides the settings on the port-channel interface level.
    uplink_structured_config: < dictionary >

Structured configuration on mlag port-channel interface:

### MLAG configuration management
< node_type_key >:

    # Custom structured config applied to MLAG peer link port-channel id.
    # Added under port_channel_interfaces.<interface> for eos_cli_config_gen.
    # Overrides the settings on the port-channel interface level.
    mlag_port_channel_structured_config: < dictionary >

    # Custom structured config applied to MLAG Peer Link (control link) SVI interface id.
    # Added under vlan_interfaces.<interface> for eos_cli_config_gen.
    # Overrides the settings on the vlan interface level.
    mlag_peer_vlan_structured_config: < dictionary >

    # Custom structured config applied to MLAG underlay L3 peering SVI interface id.
    # Added under vlan_interfaces.<interface> for eos_cli_config_gen.
    # Overrides the settings on the vlan interface level.
    mlag_peer_l3_vlan_structured_config: < dictionary >

How to test

See molecule scenario

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@carlbuchmann carlbuchmann requested a review from a team as a code owner June 9, 2022 20:23
@github-actions github-actions bot added role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jun 9, 2022
@carlbuchmann carlbuchmann force-pushed the feature-eos-designs-uplink-mlag-structured-config branch from 1941e72 to ee04cdc Compare June 9, 2022 20:29
gmuloc
gmuloc previously requested changes Jun 10, 2022
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's use a valid value for the native vlan test to not confuse the users

I have added a question regarding the order of precedence when you have structure_config existing in conjonction with these two new knobs as this is not clear for me. I think it should be documented + probably we should add some tests to verify that it works as we expect

@carlbuchmann carlbuchmann marked this pull request as draft June 10, 2022 20:12
@carlbuchmann carlbuchmann force-pushed the feature-eos-designs-uplink-mlag-structured-config branch from ee04cdc to 1367f61 Compare June 10, 2022 21:11
@carlbuchmann carlbuchmann force-pushed the feature-eos-designs-uplink-mlag-structured-config branch from 1367f61 to 986cdde Compare June 22, 2022 16:08
@carlbuchmann carlbuchmann marked this pull request as ready for review June 22, 2022 20:22
carlbuchmann and others added 7 commits June 24, 2022 08:24
for uplink and mlag interfaces
…pology.md

Co-authored-by: Claus Holbech <holbech@arista.com>
…pology.md

Co-authored-by: Claus Holbech <holbech@arista.com>
…pology.md

Co-authored-by: Claus Holbech <holbech@arista.com>
…pology.md

Co-authored-by: Claus Holbech <holbech@arista.com>
@carlbuchmann carlbuchmann force-pushed the feature-eos-designs-uplink-mlag-structured-config branch from f6e924f to df78d79 Compare June 24, 2022 12:24
@carlbuchmann
Copy link
Member Author

Thank you @ClausHolbechArista - I've committed your suggestions!

Copy link
Contributor

@lermilov lermilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista dismissed gmuloc’s stale review June 26, 2022 19:00

comment addressed in different PR.

@ClausHolbechArista ClausHolbechArista merged commit d9f6857 into aristanetworks:devel Jun 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_designs issue related to eos_designs role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants