Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_validate_state): Follow alphabetical order on generated reports #1867

Merged
merged 3 commits into from
Jun 13, 2022

Conversation

xaviramon
Copy link
Contributor

@xaviramon xaviramon commented Jun 10, 2022

Fixes #1866

Change Summary

Added end of loop and start where needed

Related Issue(s)

Fixes #1866

Component(s) name

arista.avd.eos_validate_state

Proposed changes

Keep the loops beginning and end where needed

How to test

Run against an inventory.
Previous output:

65,POD1_LEAF01A,Hardware,Transceivers manufacturers,Port 37,PASS,
66,POD1_LEAF01A,Hardware,Transceivers manufacturers,Port 32,PASS,
67,POD1_LEAF01A,NTP,Synchronised with NTP server,NTP,PASS,
68,POD1_LEAF01B,Hardware,Transceivers manufacturers,Port 30,PASS,
69,POD1_LEAF01B,Hardware,Transceivers manufacturers,Port 28,PASS,
(...)
116,POD1_LEAF01B,Hardware,Transceivers manufacturers,Port 32,PASS,
117,POD1_LEAF01B,NTP,Synchronised with NTP server,NTP,PASS,
118,POD1_LEAF01A,Interface State,Ethernet Interface & Line Protocol == "up",Ethernet3 - MLAG_PEER_POD1_LEAF01B_Ethernet3,FAIL,Interface shutdown: False - interface status: adminDown - line protocol status: down

New output:

64,POD1_LEAF01A,Hardware,Transceivers manufacturers,Port 33,PASS,
65,POD1_LEAF01A,Hardware,Transceivers manufacturers,Port 37,PASS,
66,POD1_LEAF01A,Hardware,Transceivers manufacturers,Port 32,PASS,
67,POD1_LEAF01B,Hardware,Transceivers manufacturers,Port 30,PASS,
68,POD1_LEAF01B,Hardware,Transceivers manufacturers,Port 28,PASS,
69,POD1_LEAF01B,Hardware,Transceivers manufacturers,Port 29,PASS,
(...)
115,POD1_LEAF01B,Hardware,Transceivers manufacturers,Port 32,PASS,
116,POD1_LEAF01A,NTP,Synchronised with NTP server,NTP,PASS,
117,POD1_LEAF01B,NTP,Synchronised with NTP server,NTP,PASS,

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@xaviramon xaviramon requested a review from a team as a code owner June 10, 2022 09:50
@xaviramon xaviramon changed the title Follow alphabetical order on generated reports Bug(eos_validate_state): Follow alphabetical order on generated reports Jun 10, 2022
@xaviramon xaviramon changed the title Bug(eos_validate_state): Follow alphabetical order on generated reports Fix(eos_validate_state): Follow alphabetical order on generated reports Jun 10, 2022
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@tgodaA tgodaA left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@tgodaA tgodaA merged commit b15d945 into aristanetworks:devel Jun 13, 2022
carlbuchmann pushed a commit to carlbuchmann/avd that referenced this pull request Jun 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Follow alphabetical order on generated reports
3 participants