Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix(eos_designs, eos_cli_config_gen): Fix the AVD version print in virtual environments #1876

Merged
merged 1 commit into from
Jun 15, 2022

Conversation

tgodaA
Copy link
Contributor

@tgodaA tgodaA commented Jun 10, 2022

Change Summary

ansible-galaxy collection list fails sometimes if the ansible collections path is not loaded properly. Even after the collections path is set properly in ansible.cfg, it still fails in few virtual environments. So providing the collections path is safer, ansible-galaxy collection list -p < collections_path >

Related Issue(s)

Fixes #1874

Component(s) name

Proposed changes

ansible-galaxy collection list -p COLLECTIONS_PATH

How to test

Tested locally on a virtual environment, to see if the correct collection version is printed or not.

Checklist

User Checklist

  • Test this fix in a virtual environment and verify if the correct AVD version is printed

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@tgodaA tgodaA requested a review from a team as a code owner June 10, 2022 20:51
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role role: eos_config_deploy_eapi issue related to eos_config_deploy_eapi role role: eos_designs issue related to eos_designs role role: eos_snapshot role: eos_validate_state labels Jun 10, 2022
@ClausHolbechArista
Copy link
Contributor

The purpose of the version task is to see how ansible utilities pick up the various envrironment variables and configurations. So IMO we should not override the default check, since that would produce different results than running the tools directly.

@tgodaA
Copy link
Contributor Author

tgodaA commented Jun 13, 2022

I didn't override anything here. The collection_path is picked from the anisble var collection_path itself. I am not manually giving any input. If the collection_path is wrong then everything is wrong by default as the collection_path is calculated in this step.

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team June 14, 2022 18:42
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 16bc968 into aristanetworks:devel Jun 15, 2022
carlbuchmann pushed a commit to carlbuchmann/avd that referenced this pull request Jun 21, 2022
@tgodaA tgodaA deleted the avd_version branch June 24, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role role: eos_config_deploy_eapi issue related to eos_config_deploy_eapi role role: eos_designs issue related to eos_designs role role: eos_snapshot role: eos_validate_state
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix: AVD version print in all roles
3 participants