Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feat(eos_cli_config_gen): Support bgp missing-policy under router bgp vrf address-families #1897

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Feat(eos_cli_config_gen): Support bgp missing-policy under router bgp vrf address-families #1897

merged 2 commits into from
Jun 24, 2022

Conversation

tgodaA
Copy link
Contributor

@tgodaA tgodaA commented Jun 22, 2022

Change Summary

Support bgp missing-policy under router_bgp vrf address_families

Component(s) name

arista.avd.eos_cli_config_gen

Proposed changes

router_bgp:
  vrfs:
    < vrf >:
      address_families:
        < address_family >:
          bgp:
            missing_policy:
              direction_in_action: < deny | deny-in-out | permit >
              direction_out_action: < deny | deny-in-out | permit >

How to test

molecule converge -s eos_cli_config_gen -- --limit router-bgp-v4-evpn

Checklist

User Checklist

  • N/A

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@tgodaA tgodaA requested a review from a team as a code owner June 22, 2022 18:52
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated labels Jun 22, 2022
ClausHolbechArista
ClausHolbechArista approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista requested a review from a team June 24, 2022 06:56
gmuloc
gmuloc approved these changes Jun 24, 2022
View reviewed changes
Copy link
Contributor

@gmuloc gmuloc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ClausHolbechArista ClausHolbechArista merged commit ea042d7 into aristanetworks:devel Jun 24, 2022
@tgodaA tgodaA deleted the bgp branch June 24, 2022 14:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ClausHolbechArista ClausHolbechArista ClausHolbechArista approved these changes

@gmuloc gmuloc gmuloc approved these changes

Assignees

@tgodaA tgodaA

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR state: Documentation role Updated
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tgodaA @gmuloc @ClausHolbechArista