Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc(eos_config_deploy_cvp): fix the defaults values in README #1902

Merged
merged 1 commit into from
Jun 27, 2022

Conversation

gmuloc
Copy link
Contributor

@gmuloc gmuloc commented Jun 27, 2022

Change Summary

Correct eos_config_deploy_cvp doc

Related Issue(s)

Fixes #1901

Component(s) name

arista.avd.eos_config_deploy_cvp

Proposed changes

Make the documenation reflect what is in the default file.

Checklist

Repository Checklist

  • My code has been rebased from devel before I start
  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation and documentation have been updated accordingly.
  • I have updated molecule CI testing accordingly. (check the box if not applicable)

@gmuloc gmuloc requested a review from a team as a code owner June 27, 2022 10:40
@github-actions github-actions bot added role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role state: Documentation role Updated labels Jun 27, 2022
Copy link
Contributor

@lermilov lermilov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@ClausHolbechArista ClausHolbechArista left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thank you for fixing this.

@ClausHolbechArista ClausHolbechArista merged commit a06397e into aristanetworks:devel Jun 27, 2022
@gmuloc gmuloc deleted the issue/1901 branch November 21, 2022 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_config_deploy_cvp issue related to eos_config_deploy_cvp role state: Documentation role Updated
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doc(eos_config_deploy_cvp): wrong documentation for default values for the role
3 participants