Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #205 - remove duplicate vmtracer & pim for ethernet interfaces #207

Merged
merged 1 commit into from
Aug 21, 2020
Merged

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Jul 24, 2020

After merge conflict, vmtracer and pim were added twice in template.
This PR remove duplication and do correct order to group ospf and isis in the template.

@titom73 titom73 added type: bug Something isn't working role: eos_cli_config_gen issue related to eos_cli_config_gen role labels Jul 24, 2020
@titom73 titom73 added this to the v1.1.0 milestone Jul 24, 2020
@titom73 titom73 self-assigned this Jul 24, 2020
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I reviewed and tested and what needs to be updated is the order in which pim ipv4 sparse-mode appears in the CLI.

pim ipv4 sparse-mode is between ip ospf area x and isis enable EVPN_UNDERLAY

See example below:

interface Ethernet1
   description P2P_LINK_TO_DC1-SPINE1_Ethernet6
   no switchport
   ip address 172.31.255.41/31
   ip ospf area 0.0.0.0
   pim ipv4 sparse-mode
   isis enable EVPN_UNDERLAY
   isis metric 50
   isis network point-to-point
   vmtracer vmware-esx
DC1-BL1A(config-if-Et1)#

@titom73
Copy link
Contributor Author

titom73 commented Jul 30, 2020

Not sure about which commit you took for testing, but with what I have pushed and the following yaml file

  Ethernet4/10/1:
    description: P2P_LINK_TO_CL8_Ethernet49/1
    mtu: 9214
    type: routed
    ip_address: 10.50.0.55/31
    ipv6_address: 1b11:3a00:22b0:0088::55/127
    isis_enable: EVPN_UNDERLAY
    isis_metric: 50
    isis_network_point_to_point: true
    pim:
      ipv4:
        sparse_mode: true
    ospf_network_point_to_point: true
    ospf_area: 0.0.0.0

I’ve got correct order:

interface Ethernet4/10/1
   description P2P_LINK_TO_CL8_Ethernet49/1
   mtu 9214
   no switchport
   ip address 10.50.0.55/31
   ipv6 address 1b11:3a00:22b0:0088::55/127
   ip ospf network point-to-point
   ip ospf area 0.0.0.0
   isis enable EVPN_UNDERLAY
   isis metric 50
   isis network point-to-point
   pim ipv4 sparse-mode
!

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit a63e639 into aristanetworks:devel Aug 21, 2020
@titom73 titom73 deleted the issues/205 branch October 23, 2020 20:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants