Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging extension for format option in eos and doc jinja templates #254

Merged
merged 2 commits into from
Oct 28, 2020
Merged

Logging extension for format option in eos and doc jinja templates #254

merged 2 commits into from
Oct 28, 2020

Conversation

aphillipps
Copy link
Contributor

@aphillipps aphillipps commented Sep 24, 2020 •
edited by carlbuchmann
Loading

#197 - Logging extension for format option in eos and doc jinja templates

New Logging sub-feature:

logging:
  format:
    timestamp: < high-resolution | traditional >
    hostname: < fqdn | ipv4 >
    sequence_numbers: < true | false >

Related Issue(s)

Issue #197

Tested with 4.24.2F

@titom73 titom73 added this to the v1.1.1 milestone Sep 25, 2020
@titom73 titom73 added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Sep 25, 2020
@carlbuchmann carlbuchmann self-requested a review October 3, 2020 12:58
@carlbuchmann carlbuchmann added type: enhancement New feature or request state: testing PR under testing labels Oct 3, 2020
titom73
titom73 approved these changes Oct 25, 2020
View reviewed changes
Copy link
Contributor

@titom73 titom73 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@titom73 titom73 mentioned this pull request Oct 25, 2020
Closed
12 tasks
@titom73
Copy link
Contributor

titom73 commented Oct 25, 2020

Duplicate of #261

@titom73 titom73 marked this as a duplicate of #261 Oct 25, 2020
@titom73
Copy link
Contributor

titom73 commented Oct 26, 2020

@carlbuchmann : Ready for final review

@carlbuchmann carlbuchmann self-assigned this Oct 27, 2020
carlbuchmann
carlbuchmann approved these changes Oct 28, 2020
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 6f8725a into aristanetworks:devel Oct 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@titom73 titom73 titom73 approved these changes

Assignees

@carlbuchmann carlbuchmann

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: testing PR under testing type: enhancement New feature or request
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.
3 participants
@aphillipps @titom73 @carlbuchmann