Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Enable PR labeler engine #266

Merged
merged 5 commits into from
Oct 5, 2020
Merged

Enable PR labeler engine #266

merged 5 commits into from
Oct 5, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Oct 4, 2020 •
edited
Loading

Change Summary

Create a GH action to add label to PR based on modified content.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe): Repo management

Related Issue(s)

N/A

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@titom73
Add Auto Labeler for PR
c47a730 
Create a GH action to add label to PR based on modified content.

- Label allocation file: .github/labeler.yml
- GH Action: https://github.com/actions/labeler
@titom73
Change ci target to run in base repo for PR
c7d38c7
@titom73
Copy link
Contributor Author

titom73 commented Oct 4, 2020

Action enables PR labeler using pull_request_target which runs in the context of the base repository of the pull request, rather than in the merge commit.

It is the way to not configure every single fork with a token to access this repository with R/W permissions. The solution comes from actions/labeler#12 (comment)

@titom73 titom73 mentioned this pull request Oct 4, 2020
Closed
14 tasks
@titom73 titom73 self-assigned this Oct 4, 2020
@titom73 titom73 added the type: code quality CI and development toolset label Oct 4, 2020
@titom73
Copy link
Contributor Author

titom73 commented Oct 5, 2020

Ready for review.

PR example: aristanetworks/ansible-cvp#253

@titom73 titom73 linked an issue Oct 5, 2020 that may be closed by this pull request
CI Enhancement Tracking #244
Closed
14 tasks
carlbuchmann
carlbuchmann approved these changes Oct 5, 2020
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit bfbfc1f into aristanetworks:devel Oct 5, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@titom73 titom73

Labels
type: code quality CI and development toolset
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

CI Enhancement Tracking
2 participants
@titom73 @carlbuchmann