Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix #286 - alias documention #289

Merged
merged 1 commit into from
Oct 14, 2020
Merged

fix #286 - alias documention #289

merged 1 commit into from
Oct 14, 2020

Conversation

ksator
Copy link
Contributor

@ksator ksator commented Oct 14, 2020

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

fix #286

Component(s) name

eos_cli_config_gen role

Proposed changes

updated documentation/aliases.j2

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@ksator ksator added this to the v1.1.1 milestone Oct 14, 2020
@ksator ksator self-assigned this Oct 14, 2020
@titom73 titom73 added role: eos_cli_config_gen issue related to eos_cli_config_gen role type: documentation Improvements or additions to documentation labels Oct 14, 2020
carlbuchmann
carlbuchmann approved these changes Oct 14, 2020
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 5972240 into aristanetworks:devel Oct 14, 2020
@ksator ksator deleted the issue/286 branch December 16, 2020 06:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

@aphillipps aphillipps Awaiting requested review from aphillipps

Assignees

@ksator ksator

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

update the device documentation generated by AVD for aliases
3 participants
@ksator @carlbuchmann @titom73