Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add BFD for OSPF #308

Merged
merged 3 commits into from
Oct 28, 2020
Merged

Add BFD for OSPF #308

merged 3 commits into from
Oct 28, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Oct 23, 2020

Change Summary

Types of changes

  • New feature (non-breaking change which adds functionality)

Related Issue(s)

Fixes #55

Component(s) name

Roles:

  • eos_l3ls_evpn
  • eos_cli_config_gen

Proposed changes

eos_l3ls_evpn

# Underlay OSFP | Required when < underlay_routing_protocol > == OSPF
underlay_ospf_process_id: < process_id | Default -> 100 >
underlay_ospf_area: < ospf_area | Default -> 0.0.0.0 >
underlay_ospf_max_lsa: < lsa | Default -> 12000 >
underlay_ospf_bfd_enable: < true | false | Default -> false >

eos_cli_config_gen

router_ospf:
  process_ids:
    100:
      passive_interface_default: true
      router_id: 192.168.255.7
      no_passive_interfaces:
        - Ethernet1
        - Ethernet2
      bfd_enable: true
      max_lsa: 12000

How to test

Iterate one of these data

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@titom73 titom73 added this to the v1.1.1 milestone Oct 23, 2020
@titom73 titom73 self-assigned this Oct 23, 2020
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_l3ls_evpn issue related to eos_l3ls_evpn role type: documentation Improvements or additions to documentation labels Oct 23, 2020
@titom73 titom73 changed the title Issues/55 1 Add BFD for OSPF Oct 23, 2020
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, tested successfully with avd-validation lab.

@carlbuchmann carlbuchmann merged commit a2e6ae2 into aristanetworks:devel Oct 28, 2020
@titom73 titom73 deleted the issues/55-1 branch January 13, 2021 08:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role role: eos_l3ls_evpn issue related to eos_l3ls_evpn role type: documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

OSPF Underlay Tuning
2 participants