-
Notifications
You must be signed in to change notification settings - Fork 220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ip-helper for dhcp-relay #345
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Apply data model from eos_cli_config_gen in eos_l3ls_evpn ``` tenants: # Tenant A Specific Information - VRFs / VLANs Tenant_A: mac_vrf_vni_base: 10000 vrfs: TENANT_A_PROJECT01: vrf_vni: 11 svis: 311: name: 'PR01-TRUST-DHCP' tags: [POD01] enabled: true ip_address_virtual: 10.1.31.254/24 ip_helpers: 1.1.1.1: source_interface: lo100 ``` Rendering is as below for eos_cli_config_gen: ``` Vlan311: tenant: Tenant_A tags: ['POD01'] description: PR01-TRUST-DHCP vrf: TENANT_A_PROJECT01 ip_address_virtual: 10.1.31.254/24 ip_helpers: 1.1.1.1: source_interface: lo100 vrf: TENANT_A_PROJECT01 ``` And EOS configuration: ``` interface Vlan311 description PR01-TRUST-DHCP vrf TENANT_A_PROJECT01 ip address virtual 10.1.31.254/24 ip helper-address 1.1.1.1 vrf TENANT_A_PROJECT01 source-interface lo100 ```
titom73
changed the title
Implement ip-helper for dhcp-relay #312
Implement ip-helper for dhcp-relay
Nov 3, 2020
github-actions
bot
added
role: eos_l3ls_evpn
issue related to eos_l3ls_evpn role
type: documentation
Improvements or additions to documentation
labels
Nov 3, 2020
@titom73 - one of the ideas I had regarding the eos_lsls_evpn data model for SVIs, is to implement hierarchical profiles configuration as the configuration might be repetitive across many interfaces. |
|
Add knob to support source VRF to originate packets. If not set, current VRF is used
Ready for testing and review |
carlbuchmann
approved these changes
Nov 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
role: eos_l3ls_evpn
issue related to eos_l3ls_evpn role
type: documentation
Improvements or additions to documentation
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change Summary
Apply data model from eos_cli_config_gen in eos_l3ls_evpn
Types of changes
Related Issue(s)
Fixes #312
Component(s) name
eos_l3ls_evpn
Proposed changes
Apply data model from
eos_cli_config_gen
ineos_l3ls_evpn
How to test
Rendering is as below for
eos_cli_config_gen
:And EOS configuration:
Checklist:
pre-commit
,make linting
andmake sanity-lint
).