Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ospf: support setting path cost #367

Merged
merged 1 commit into from
Nov 16, 2020
Merged

ospf: support setting path cost #367

merged 1 commit into from
Nov 16, 2020

Conversation

c-po
Copy link
Contributor

@c-po c-po commented Nov 16, 2020

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

This implements #366

Component(s) name

Proposed changes

How to test

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role type: documentation Improvements or additions to documentation labels Nov 16, 2020
carlbuchmann
carlbuchmann approved these changes Nov 16, 2020
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM - resolves #366

@carlbuchmann carlbuchmann added this to the v1.1.1 milestone Nov 16, 2020
@carlbuchmann carlbuchmann self-assigned this Nov 16, 2020
@carlbuchmann
Copy link
Member

@c-po thank you for this contribution!

@carlbuchmann carlbuchmann merged commit 308dea9 into aristanetworks:devel Nov 16, 2020
@c-po c-po deleted the issues/366 branch November 8, 2021 06:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@carlbuchmann carlbuchmann

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.
2 participants
@c-po @carlbuchmann