Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect rstrip configuration #394 #395

Merged
merged 1 commit into from
Nov 28, 2020
Merged

Fix incorrect rstrip configuration #394 #395

merged 1 commit into from
Nov 28, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Nov 27, 2020

Change Summary

Remove - from condition lines since it breaks multiline output for
banner.

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #394

Component(s) name

eos_cli_config_gen

Proposed changes

Use AVD standard condition line without -

How to test

banners:
  login: |-
    My first banner line
    Connected to Device $(hostname) EOF

Result should be:

!
banner login
My first banner line
    Connected to Device $(hostname) EOF
!

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

Rmove `-` from condition lines since it breaks multiline output for
banner.
@titom73 titom73 added the type: bug Something isn't working label Nov 27, 2020
@titom73 titom73 self-assigned this Nov 27, 2020
@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Nov 27, 2020
@titom73
Copy link
Contributor Author

titom73 commented Nov 27, 2020

Hi @c-po
Ready for your review

@c-po
Copy link
Contributor

c-po commented Nov 27, 2020

LGTM, Jinja2 is sometimes very picky about its new line stuff.

Thanks for giving me the opportunity to do a review 😄

Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann added this to the v1.1.1 milestone Nov 28, 2020
@carlbuchmann carlbuchmann merged commit 9148390 into aristanetworks:devel Nov 28, 2020
@titom73 titom73 deleted the issues/394 branch January 13, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role type: bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Banner template has rstrip function configured and remove some lines
3 participants