Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement storm_control for ethernet and port-channel interfaces #399

Merged
merged 4 commits into from
Nov 29, 2020
Merged

Implement storm_control for ethernet and port-channel interfaces #399

merged 4 commits into from
Nov 29, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Nov 28, 2020

Change Summary

Add storm-control support to ethernet-interfaces.j2 and port-channel-interfaces.j2.
The port-profile data model can look like:

storm_control:
  <broadcast | multicast | all>:
    level: <storm-control-level>
    unit: <percent | pps>

Types of changes

  • New feature (non-breaking change which adds functionality)

Related Issue(s)

Fixes #154

Component(s) name

eos_cli_config_gen

Proposed changes

Update template to support following data-model:

  <Ethernet_interface_2 >:
    storm_control:
      all:
        level: < Configure maximum storm-control level >
        unit: < percent | pps >
      broadcast:
        level: < Configure maximum storm-control level >
        unit: < percent | pps >
      multicast:
        level: < Configure maximum storm-control level >
        unit: < percent | pps >
      'unknown-unicast':
        level: < Configure maximum storm-control level >
        unit: < percent | pps >

How to test

Update your host-vars to use the data-model described above.

Checklist:

  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have updated molecule CI testing accordingly
  • I have read the CONTRIBUTING document.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).

@titom73
Implement storm_control as per issue #154
96a652f 
Use Following input data model on either Ethernet Interfaces or Port-Channels:

```
storm_control:
  all:
    level: 10
    unit: pps
  'unknown-unicast':
    level: 1
    unit: percent
```

Output generated:

```
interface Ethernet1
   description P2P_LINK_TO_DC1-SPINE1_Ethernet7
   no switchport
   ip address 172.31.255.17/31
   storm-control all level pps 10
   storm-control unknown-unicast level 1
!
```
@titom73
Update documentation for #154
63e008e
@titom73
Update CI acritfacts
546cc3c
@titom73 titom73 added this to the v1.1.1 milestone Nov 28, 2020
@titom73 titom73 requested a review from carlbuchmann November 28, 2020 13:56
@titom73 titom73 self-assigned this Nov 28, 2020
@github-actions github-actions bot added role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation labels Nov 28, 2020
@titom73
Copy link
Contributor Author

titom73 commented Nov 28, 2020

Ready for review

carlbuchmann
carlbuchmann approved these changes Nov 29, 2020
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested with avd-validation lab! LGTM!

@carlbuchmann carlbuchmann merged commit f8522ee into aristanetworks:devel Nov 29, 2020
@titom73 titom73 deleted the issues/154-storm-control branch January 13, 2021 08:25
@titom73 titom73 mentioned this pull request Sep 24, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@titom73 titom73

Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role state: CI Updated CI scenario have been updated in the PR type: documentation Improvements or additions to documentation
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

Add storm-control support
2 participants
@titom73 @carlbuchmann