Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add extra newline after custom_template include #403

Merged
merged 1 commit into from
Nov 30, 2020
Merged

Add extra newline after custom_template include #403

merged 1 commit into from
Nov 30, 2020

Conversation

ClausHolbechArista
Copy link
Contributor

Change Summary

Add extra newline after custom_template include

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe):

Related Issue(s)

Fixes #391

Component(s) name

eos_cli_config_gen

Proposed changes

Adding an extra empty line in custom_templates.j2 to ensure that the first line of a templates is not rendered on the same line as the last line of the previous template.

How to test

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@github-actions github-actions bot added the role: eos_cli_config_gen issue related to eos_cli_config_gen role label Nov 30, 2020
carlbuchmann
carlbuchmann approved these changes Nov 30, 2020
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann added this to the v1.1.1 milestone Nov 30, 2020
@carlbuchmann carlbuchmann merged commit d62b0fc into aristanetworks:devel Nov 30, 2020
@ClausHolbechArista ClausHolbechArista deleted the custom-template-bugfix branch July 9, 2021 19:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees
No one assigned
Labels
role: eos_cli_config_gen issue related to eos_cli_config_gen role
Projects
None yet
Milestone
v1.1.1
Development

Successfully merging this pull request may close these issues.

Add delimiter "!" for custom_templates output in eos_cli_config_gen.
2 participants
@ClausHolbechArista @carlbuchmann