Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update CI image to use stable v1 #417

Merged
merged 2 commits into from
Dec 7, 2020
Merged

Update CI image to use stable v1 #417

merged 2 commits into from
Dec 7, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Dec 5, 2020

Change Summary

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe): Continuous Integration

Related Issue(s)

N/A

Component(s) name

N/A

Proposed changes

avdteam/base image has stable tags <{pythonVersion}-v{gitTag}> compare to current tag where image can change based on commit in docker repository. This behavior can lead to CI issue or slow down CI image development.

Proposed tag is equal to current <python-version> image.

How to test

CI must be all green to validate change

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@github-actions github-actions bot added the type: code quality CI and development toolset label Dec 5, 2020
@titom73 titom73 self-assigned this Dec 5, 2020
@titom73 titom73 marked this pull request as ready for review December 6, 2020 11:51
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@carlbuchmann carlbuchmann merged commit 917245b into aristanetworks:devel Dec 7, 2020
@titom73 titom73 deleted the features/update-ci-image-to-v1 branch January 13, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: code quality CI and development toolset
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants