Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pre-commit configuration #419

Merged
merged 2 commits into from
Dec 6, 2020
Merged

Update pre-commit configuration #419

merged 2 commits into from
Dec 6, 2020

Conversation

titom73
Copy link
Contributor

@titom73 titom73 commented Dec 5, 2020

Change Summary

  • Ignore eof fixer for jinja files
  • Update pre-commit version

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes)
  • Documentation content changes
  • Other (please describe): Code Quality

Related Issue(s)

Component(s) name

pre-commit

How to test

Checklist:

  • I have read the CONTRIBUTING document.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • All new and existing tests passed (pre-commit, make linting and make sanity-lint).
  • I have updated molecule CI testing accordingly

@titom73 titom73 self-assigned this Dec 5, 2020
@github-actions github-actions bot added the type: dependencies Pull requests that update a dependency file label Dec 5, 2020
carlbuchmann
carlbuchmann approved these changes Dec 6, 2020
View reviewed changes
Copy link
Member

@carlbuchmann carlbuchmann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@carlbuchmann carlbuchmann merged commit 86c47ac into aristanetworks:devel Dec 6, 2020
@titom73 titom73 deleted the features/ci-upgrade-pre-commit branch January 13, 2021 08:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@carlbuchmann carlbuchmann carlbuchmann approved these changes

Assignees

@titom73 titom73

Labels
type: dependencies Pull requests that update a dependency file
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@titom73 @carlbuchmann